Skip to content

Bump pynintendoparental to 2.1.1#158779

Merged
joostlek merged 1 commit into
home-assistant:devfrom
pantherale0:bump/pynintendoparental211
Dec 12, 2025
Merged

Bump pynintendoparental to 2.1.1#158779
joostlek merged 1 commit into
home-assistant:devfrom
pantherale0:bump/pynintendoparental211

Conversation

@pantherale0
Copy link
Copy Markdown
Contributor

Proposed change

SSIA

Please can we include for 2025.12.3?

Release: https://github.com/pantherale0/pynintendoparental/releases/tag/2.1.1
Diff: pantherale0/pynintendoparental@2.1.0...2.1.1

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@joostlek joostlek added this to the 2025.12.3 milestone Dec 12, 2025
@joostlek joostlek merged commit 61c7ac8 into home-assistant:dev Dec 12, 2025
67 checks passed
@frenck
Copy link
Copy Markdown
Member

frenck commented Dec 12, 2025

This PR cannot be included in a patch release, as it is depending on #158285 and #158487, that are not in the 2025.12 branch.

../Frenck

                       

Blogging my personal ramblings at frenck.dev

@frenck frenck removed this from the 2025.12.3 milestone Dec 12, 2025
@pantherale0
Copy link
Copy Markdown
Contributor Author

This PR cannot be included in a patch release, as it is depending on #158285 and #158487, that are not in the 2025.12 branch.

../Frenck

                       

Blogging my personal ramblings at frenck.dev

Those PRs could also be included?

@binarin
Copy link
Copy Markdown

binarin commented Dec 13, 2025

@pantherale0 When I manually upgrade to this versions it works for some time before failing with the following exception (by looking at pynintendoauth I see that it has _perform_refresh with underscore at the start, not perform_refresh):

2025-12-13 09:00:22.670 ERROR (MainThread) [homeassistant.components.nintendo_parental_controls.coordinator] Unexpected error fetching nintendo_parental_controls data
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 419, in _async_refresh
    self.data = await self._async_update_data()
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/nintendo_parental_controls/coordinator.py", line 51

    return await self.api.update()
           ^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.13/site-packages/pynintendoparental/__init__.py", line 53, in update
    await self._get_devices()
  File "/usr/local/lib/python3.13/site-packages/pynintendoparental/__init__.py", line 34, in _get_devices
    response = await self._api.async_get_account_devices()
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.13/site-packages/pynintendoparental/api.py", line 117, in async_get_account_

    return await self.send_request(endpoint="get_account_devices")
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.13/site-packages/pynintendoparental/api.py", line 67, in send_request
    await self._auth.perform_refresh()
          ^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'Authenticator' object has no attribute 'perform_refresh'

@github-actions github-actions Bot locked and limited conversation to collaborators Dec 14, 2025
@abmantis abmantis added this to the 2025.12.4 milestone Dec 16, 2025
@abmantis
Copy link
Copy Markdown
Member

Milestone added since it is needed for #159120

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nintendo Switch parental controls update required

6 participants