Update advanced_options display text for MQTT#158728
Merged
Merged
Conversation
Contributor
|
Hey there @emontnemery, @jbouwh, @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
Author
|
@jbouwh sure thing, wasn’t able to run the tests locally or review other PRs yet so it was in draft, but I imagine the GitHub actions also run tests? |
Contributor
We don't always have tests for translations. |
BennnLi
pushed a commit
to BennnLi/homeassistant-core
that referenced
this pull request
Dec 12, 2025
frenck
pushed a commit
that referenced
this pull request
Dec 12, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Updating the text in the image to match the button
Type of change
It looks like @emontnemery used "Code quality improvements" in the similar #157643, but since the change is visible to end users that "felt" like it could confuse any future release automation. Does this suggest a need for adding another option?
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: