Suppress roborock failures under some unavailability threshold#158673
Merged
joostlek merged 3 commits intoDec 13, 2025
Conversation
We aggressively refresh roborock devices local channel (every 30 seconds) and there is a known issue where devices go unavailable around 3am every day for a period of ~1 minute which causes log spam during a non-critical background refresh. We instead will suppress refresh failures until a minimum unavailability threshold has passed.
Contributor
|
Hey there @Lash-L, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a known issue where Roborock devices temporarily go offline around 3am for approximately 1 minute, causing log spam during routine background refreshes. The solution implements an unavailability threshold that suppresses reporting update failures until 2 minutes of consecutive failures have occurred.
Key changes:
- Added time-based failure suppression logic to avoid marking devices as unavailable during brief outages
- Improved exception handling by changing
HomeAssistantErrortoUpdateFailedinupdate_map()for consistency - Added comprehensive test coverage for the unavailability threshold behavior
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| homeassistant/components/roborock/coordinator.py | Implements unavailability threshold by tracking last successful update time and suppressing failures under 2 minutes; changes update_map() to raise UpdateFailed instead of HomeAssistantError for consistency |
| tests/components/roborock/test_init.py | Adds comprehensive test that verifies entities remain available during short failure periods (90 seconds), become unavailable after exceeding threshold (4.5 minutes total), and recover when updates resume |
patman15
approved these changes
Dec 13, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
joostlek
approved these changes
Dec 13, 2025
Member
|
Should this be picked for a patch? |
Contributor
Author
See the PR description, i was expecting to wait on this, but maybe i'm being too conservative. |
Member
|
OH, sorry, I missed the description 😓 Sorry |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We aggressively refresh roborock devices local channel (every 30 seconds) and there is a known issue where devices go unavailable around 3am every day for a period of ~1 minute which causes log spam during a non-critical background refresh. We instead will suppress refresh failures until a minimum unavailability threshold has passed.
Proposed change
Suppress roborock failures under some unavailability threshold to handle the 3am unavailability issue.
Other members: Very happy to have review/approval, but I would request you let me merge this myself. Also, I would like to target this for 2025.1.x, and not a patch release since it is a long standing issue.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: