Skip to content

Fix roborock off peak electricity timer#158292

Merged
zweckj merged 1 commit into
home-assistant:devfrom
allenporter:valley-electricity
Dec 9, 2025
Merged

Fix roborock off peak electricity timer#158292
zweckj merged 1 commit into
home-assistant:devfrom
allenporter:valley-electricity

Conversation

@allenporter
Copy link
Copy Markdown
Contributor

Proposed change

Fix roborock off peak electricity timer time entities.

The existing code was calling the wrong API methods, which is defined here: https://github.com/Python-roborock/python-roborock/blob/main/roborock/devices/traits/v1/valley_electricity_timer.py -- this adds tests for the entities, sharing a fixture with the existing do not disturb time entities.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@allenporter allenporter added this to the 2025.12.3 milestone Dec 9, 2025
Copilot AI review requested due to automatic review settings December 9, 2025 02:58
@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Dec 9, 2025

Hey there @Lash-L, mind taking a look at this pull request as it has been labeled with an integration (roborock) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of roborock can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign roborock Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug in the Roborock integration's off-peak electricity timer time entities by correcting the API method calls to match the upstream library's interface.

  • Changes the off-peak timer entities to use the correct set_timer method instead of the incorrect update_value method
  • Adds comprehensive test coverage for both off-peak timer entities (start and end times)
  • Updates test fixtures to properly mock the valley electricity timer trait

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
homeassistant/components/roborock/time.py Fixed off-peak timer entities to call trait.set_timer() with ValleyElectricityTimer dataclass instead of incorrect update_value() method
tests/components/roborock/test_time.py Added test cases for off-peak start and end time entities, refactored test structure to use callable parameter for flexibility
tests/components/roborock/conftest.py Added make_valley_electric_timer fixture function to properly mock the valley electricity timer trait with set_timer method
tests/components/roborock/mock_data.py Added VALLEY_ELECTRICITY_TIMER mock data constant for test fixtures

@zweckj zweckj merged commit cceaff7 into home-assistant:dev Dec 9, 2025
41 of 42 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Roborock on/off peak time chamge not work after HA Core update

4 participants