Fix roborock off peak electricity timer#158292
Merged
Merged
Conversation
Contributor
|
Hey there @Lash-L, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the Roborock integration's off-peak electricity timer time entities by correcting the API method calls to match the upstream library's interface.
- Changes the off-peak timer entities to use the correct
set_timermethod instead of the incorrectupdate_valuemethod - Adds comprehensive test coverage for both off-peak timer entities (start and end times)
- Updates test fixtures to properly mock the valley electricity timer trait
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
homeassistant/components/roborock/time.py |
Fixed off-peak timer entities to call trait.set_timer() with ValleyElectricityTimer dataclass instead of incorrect update_value() method |
tests/components/roborock/test_time.py |
Added test cases for off-peak start and end time entities, refactored test structure to use callable parameter for flexibility |
tests/components/roborock/conftest.py |
Added make_valley_electric_timer fixture function to properly mock the valley electricity timer trait with set_timer method |
tests/components/roborock/mock_data.py |
Added VALLEY_ELECTRICITY_TIMER mock data constant for test fixtures |
zweckj
approved these changes
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Fix roborock off peak electricity timer time entities.
The existing code was calling the wrong API methods, which is defined here: https://github.com/Python-roborock/python-roborock/blob/main/roborock/devices/traits/v1/valley_electricity_timer.py -- this adds tests for the entities, sharing a fixture with the existing do not disturb time entities.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: