Skip to content

Fix webhook exception when empty json data is sent#158254

Merged
MartinHjelmare merged 6 commits into
home-assistant:devfrom
mikedast:fix-webhook-empty-json-exception2
Dec 8, 2025
Merged

Fix webhook exception when empty json data is sent#158254
MartinHjelmare merged 6 commits into
home-assistant:devfrom
mikedast:fix-webhook-empty-json-exception2

Conversation

@mikedast
Copy link
Copy Markdown
Contributor

@mikedast mikedast commented Dec 8, 2025

Proposed change

As describe in #148298, Dahua cameras web hook implementation, send a GET request, and set the "Content-Type" header to application/json, without providing any payload. This will result in an exception in "homeassistant/components/webhook/init.py":

2025-07-06 17:17:35.106 ERROR (MainThread) [homeassistant.components.webhook] Error processing webhook ivs-patio-5daAWNr1Q1ZSGRcBIcnK7BJ2
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/components/webhook/__init__.py", line 194, in async_handle_webhook
    response: Response | None = await webhook["handler"](hass, webhook_id, request)
                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/webhook/trigger.py", line 64, in _handle_webhook
    base_result["json"] = await request.json()
                          ^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/http/__init__.py", line 310, in json
    return json_loads(await self.read())
  File "/usr/src/homeassistant/homeassistant/util/json.py", line 42, in json_loads
    return orjson.loads(obj)  # type:ignore[no-any-return]
           ~~~~~~~~~~~~^^^^^
orjson.JSONDecodeError: Input is a zero-length, empty document: line 1 column 1 (char 0)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Dec 8, 2025

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (webhook) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of webhook can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign webhook Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@mikedast
Copy link
Copy Markdown
Contributor Author

mikedast commented Dec 8, 2025

Sorry I run into commit authoring issues with previous PR, decided to create a new branch.

@MartinHjelmare MartinHjelmare self-assigned this Dec 8, 2025
@MartinHjelmare
Copy link
Copy Markdown
Member

Please stop merging the dev branch into your feature branch. We can't merge the PR until we see that CI passes. Whenever you update the branch we need to run CI again.

We only need to merge dev branch into the feature branch if there's a merge conflict or if we know we need something from dev.

@MartinHjelmare MartinHjelmare changed the title Fix webhook exception when empty json data is sent (New) Fix webhook exception when empty json data is sent Dec 8, 2025
@MartinHjelmare MartinHjelmare added this to the 2025.12.3 milestone Dec 8, 2025
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit b120ae8 into home-assistant:dev Dec 8, 2025
66 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Webhook trigger fails when http GET call do not include any payload

3 participants