Skip to content

Fix secure URLs for promotional game media in Xbox integration #158162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zweckj merged 1 commit into from
Dec 7, 2025
Merged

Fix secure URLs for promotional game media in Xbox integration #158162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion homeassistant/components/xbox/media_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -630,7 +630,7 @@ def _build_media_items_promotional(
title=image.type,
can_play=True,
can_expand=False,
thumbnail=image.url,
thumbnail=to_https(image.url),
)
for image in game.images
]
Expand Down
48 changes: 24 additions & 24 deletions tests/components/xbox/snapshots/test_media_source.ambr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@
'media_class': <MediaClass.VIDEO: 'video'>,
'media_content_id': 'media-source://xbox/271958441785640/1297287135/game_media/0',
'media_content_type': <MediaClass.VIDEO: 'video'>,
'thumbnail': 'http://store-images.s-microsoft.com/image/apps.35725.65457035095819016.56f55216-1bb9-40aa-8796-068cf3075fc1.c4bf34f8-ad40-4af3-914e-a85e75a76bed',
'thumbnail': 'https://store-images.s-microsoft.com/image/apps.35725.65457035095819016.56f55216-1bb9-40aa-8796-068cf3075fc1.c4bf34f8-ad40-4af3-914e-a85e75a76bed',
'title': 'Screenshot',
}),
dict({
Expand All @@ -270,7 +270,7 @@
'media_class': <MediaClass.VIDEO: 'video'>,
'media_content_id': 'media-source://xbox/271958441785640/1297287135/game_media/1',
'media_content_type': <MediaClass.VIDEO: 'video'>,
'thumbnail': 'http://store-images.s-microsoft.com/image/apps.64736.65457035095819016.56f55216-1bb9-40aa-8796-068cf3075fc1.6491fb2f-52e7-4129-bcbd-d23a67117ae0',
'thumbnail': 'https://store-images.s-microsoft.com/image/apps.64736.65457035095819016.56f55216-1bb9-40aa-8796-068cf3075fc1.6491fb2f-52e7-4129-bcbd-d23a67117ae0',
'title': 'BrandedKeyArt',
}),
dict({
Expand All @@ -281,7 +281,7 @@
'media_class': <MediaClass.VIDEO: 'video'>,
'media_content_id': 'media-source://xbox/271958441785640/1297287135/game_media/2',
'media_content_type': <MediaClass.VIDEO: 'video'>,
'thumbnail': 'http://store-images.s-microsoft.com/image/apps.55545.65457035095819016.56f55216-1bb9-40aa-8796-068cf3075fc1.4c2daefb-fbf6-4b90-b392-bf8ecc39a92e',
'thumbnail': 'https://store-images.s-microsoft.com/image/apps.55545.65457035095819016.56f55216-1bb9-40aa-8796-068cf3075fc1.4c2daefb-fbf6-4b90-b392-bf8ecc39a92e',
'title': 'TitledHeroArt',
}),
dict({
Expand All @@ -292,7 +292,7 @@
'media_class': <MediaClass.VIDEO: 'video'>,
'media_content_id': 'media-source://xbox/271958441785640/1297287135/game_media/3',
'media_content_type': <MediaClass.VIDEO: 'video'>,
'thumbnail': 'http://store-images.s-microsoft.com/image/apps.22570.65457035095819016.56f55216-1bb9-40aa-8796-068cf3075fc1.bf29284d-808a-4e4a-beaa-6621c9898d0e',
'thumbnail': 'https://store-images.s-microsoft.com/image/apps.22570.65457035095819016.56f55216-1bb9-40aa-8796-068cf3075fc1.bf29284d-808a-4e4a-beaa-6621c9898d0e',
'title': 'Poster',
}),
dict({
Expand All @@ -303,7 +303,7 @@
'media_class': <MediaClass.VIDEO: 'video'>,
'media_content_id': 'media-source://xbox/271958441785640/1297287135/game_media/4',
'media_content_type': <MediaClass.VIDEO: 'video'>,
'thumbnail': 'http://store-images.s-microsoft.com/image/apps.55545.65457035095819016.56f55216-1bb9-40aa-8796-068cf3075fc1.4c2daefb-fbf6-4b90-b392-bf8ecc39a92e',
'thumbnail': 'https://store-images.s-microsoft.com/image/apps.55545.65457035095819016.56f55216-1bb9-40aa-8796-068cf3075fc1.4c2daefb-fbf6-4b90-b392-bf8ecc39a92e',
'title': 'SuperHeroArt',
}),
dict({
Expand All @@ -314,7 +314,7 @@
'media_class': <MediaClass.VIDEO: 'video'>,
'media_content_id': 'media-source://xbox/271958441785640/1297287135/game_media/5',
'media_content_type': <MediaClass.VIDEO: 'video'>,
'thumbnail': 'http://store-images.s-microsoft.com/image/apps.45451.65457035095819016.56f55216-1bb9-40aa-8796-068cf3075fc1.3abf2cc3-00cc-417d-a93d-97110cdfb261',
'thumbnail': 'https://store-images.s-microsoft.com/image/apps.45451.65457035095819016.56f55216-1bb9-40aa-8796-068cf3075fc1.3abf2cc3-00cc-417d-a93d-97110cdfb261',
'title': 'BoxArt',
}),
dict({
Expand All @@ -325,7 +325,7 @@
'media_class': <MediaClass.VIDEO: 'video'>,
'media_content_id': 'media-source://xbox/271958441785640/1297287135/game_media/6',
'media_content_type': <MediaClass.VIDEO: 'video'>,
'thumbnail': 'http://store-images.s-microsoft.com/image/apps.35072.13670972585585116.70570f0d-17aa-4f97-b692-5412fa183673.25a97451-9369-4f6b-b66b-3427913235eb',
'thumbnail': 'https://store-images.s-microsoft.com/image/apps.35072.13670972585585116.70570f0d-17aa-4f97-b692-5412fa183673.25a97451-9369-4f6b-b66b-3427913235eb',
'title': 'Logo',
}),
dict({
Expand All @@ -336,7 +336,7 @@
'media_class': <MediaClass.VIDEO: 'video'>,
'media_content_id': 'media-source://xbox/271958441785640/1297287135/game_media/7',
'media_content_type': <MediaClass.VIDEO: 'video'>,
'thumbnail': 'http://store-images.s-microsoft.com/image/apps.45451.65457035095819016.56f55216-1bb9-40aa-8796-068cf3075fc1.3abf2cc3-00cc-417d-a93d-97110cdfb261',
'thumbnail': 'https://store-images.s-microsoft.com/image/apps.45451.65457035095819016.56f55216-1bb9-40aa-8796-068cf3075fc1.3abf2cc3-00cc-417d-a93d-97110cdfb261',
'title': 'FeaturePromotionalSquareArt',
}),
dict({
Expand All @@ -347,7 +347,7 @@
'media_class': <MediaClass.VIDEO: 'video'>,
'media_content_id': 'media-source://xbox/271958441785640/1297287135/game_media/8',
'media_content_type': <MediaClass.VIDEO: 'video'>,
'thumbnail': 'http://store-images.s-microsoft.com/image/apps.38628.65457035095819016.56f55216-1bb9-40aa-8796-068cf3075fc1.c2a205af-5146-405b-b2b7-56845351f1f3',
'thumbnail': 'https://store-images.s-microsoft.com/image/apps.38628.65457035095819016.56f55216-1bb9-40aa-8796-068cf3075fc1.c2a205af-5146-405b-b2b7-56845351f1f3',
'title': 'Screenshot',
}),
dict({
Expand All @@ -358,7 +358,7 @@
'media_class': <MediaClass.VIDEO: 'video'>,
'media_content_id': 'media-source://xbox/271958441785640/1297287135/game_media/9',
'media_content_type': <MediaClass.VIDEO: 'video'>,
'thumbnail': 'http://store-images.s-microsoft.com/image/apps.22150.65457035095819016.56f55216-1bb9-40aa-8796-068cf3075fc1.b147895c-e947-424d-a731-faefc8c9906a',
'thumbnail': 'https://store-images.s-microsoft.com/image/apps.22150.65457035095819016.56f55216-1bb9-40aa-8796-068cf3075fc1.b147895c-e947-424d-a731-faefc8c9906a',
'title': 'Screenshot',
}),
dict({
Expand All @@ -369,7 +369,7 @@
'media_class': <MediaClass.VIDEO: 'video'>,
'media_content_id': 'media-source://xbox/271958441785640/1297287135/game_media/10',
'media_content_type': <MediaClass.VIDEO: 'video'>,
'thumbnail': 'http://store-images.s-microsoft.com/image/apps.37559.65457035095819016.56f55216-1bb9-40aa-8796-068cf3075fc1.479d2dc1-db2d-4ffa-8c54-a2bebb093ec6',
'thumbnail': 'https://store-images.s-microsoft.com/image/apps.37559.65457035095819016.56f55216-1bb9-40aa-8796-068cf3075fc1.479d2dc1-db2d-4ffa-8c54-a2bebb093ec6',
'title': 'Screenshot',
}),
dict({
Expand All @@ -380,7 +380,7 @@
'media_class': <MediaClass.VIDEO: 'video'>,
'media_content_id': 'media-source://xbox/271958441785640/1297287135/game_media/11',
'media_content_type': <MediaClass.VIDEO: 'video'>,
'thumbnail': 'http://store-images.s-microsoft.com/image/apps.32737.65457035095819016.56f55216-1bb9-40aa-8796-068cf3075fc1.6a16ae3e-2918-46e9-90d9-232c79cb9d9d',
'thumbnail': 'https://store-images.s-microsoft.com/image/apps.32737.65457035095819016.56f55216-1bb9-40aa-8796-068cf3075fc1.6a16ae3e-2918-46e9-90d9-232c79cb9d9d',
'title': 'Screenshot',
}),
dict({
Expand All @@ -391,7 +391,7 @@
'media_class': <MediaClass.VIDEO: 'video'>,
'media_content_id': 'media-source://xbox/271958441785640/1297287135/game_media/12',
'media_content_type': <MediaClass.VIDEO: 'video'>,
'thumbnail': 'http://store-images.s-microsoft.com/image/apps.57046.65457035095819016.56f55216-1bb9-40aa-8796-068cf3075fc1.0c0dd072-aa27-4e83-9010-474dfbb42277',
'thumbnail': 'https://store-images.s-microsoft.com/image/apps.57046.65457035095819016.56f55216-1bb9-40aa-8796-068cf3075fc1.0c0dd072-aa27-4e83-9010-474dfbb42277',
'title': 'Screenshot',
}),
dict({
Expand All @@ -402,7 +402,7 @@
'media_class': <MediaClass.VIDEO: 'video'>,
'media_content_id': 'media-source://xbox/271958441785640/1297287135/game_media/13',
'media_content_type': <MediaClass.VIDEO: 'video'>,
'thumbnail': 'http://store-images.s-microsoft.com/image/apps.19315.65457035095819016.56f55216-1bb9-40aa-8796-068cf3075fc1.6293a7b7-07ca-4df0-9eea-6018285a0a8d',
'thumbnail': 'https://store-images.s-microsoft.com/image/apps.19315.65457035095819016.56f55216-1bb9-40aa-8796-068cf3075fc1.6293a7b7-07ca-4df0-9eea-6018285a0a8d',
'title': 'Screenshot',
}),
dict({
Expand All @@ -413,7 +413,7 @@
'media_class': <MediaClass.VIDEO: 'video'>,
'media_content_id': 'media-source://xbox/271958441785640/1297287135/game_media/14',
'media_content_type': <MediaClass.VIDEO: 'video'>,
'thumbnail': 'http://store-images.s-microsoft.com/image/apps.23374.65457035095819016.56f55216-1bb9-40aa-8796-068cf3075fc1.66498a73-52f5-4247-a1e2-d3c84b9b315d',
'thumbnail': 'https://store-images.s-microsoft.com/image/apps.23374.65457035095819016.56f55216-1bb9-40aa-8796-068cf3075fc1.66498a73-52f5-4247-a1e2-d3c84b9b315d',
'title': 'Screenshot',
}),
dict({
Expand All @@ -424,7 +424,7 @@
'media_class': <MediaClass.VIDEO: 'video'>,
'media_content_id': 'media-source://xbox/271958441785640/1297287135/game_media/15',
'media_content_type': <MediaClass.VIDEO: 'video'>,
'thumbnail': 'http://store-images.s-microsoft.com/image/apps.64646.65457035095819016.56f55216-1bb9-40aa-8796-068cf3075fc1.83182b76-4294-496d-90a7-f4e31e7aa80a',
'thumbnail': 'https://store-images.s-microsoft.com/image/apps.64646.65457035095819016.56f55216-1bb9-40aa-8796-068cf3075fc1.83182b76-4294-496d-90a7-f4e31e7aa80a',
'title': 'Screenshot',
}),
dict({
Expand All @@ -435,7 +435,7 @@
'media_class': <MediaClass.VIDEO: 'video'>,
'media_content_id': 'media-source://xbox/271958441785640/1297287135/game_media/16',
'media_content_type': <MediaClass.VIDEO: 'video'>,
'thumbnail': 'http://store-images.s-microsoft.com/image/apps.24470.65457035095819016.56f55216-1bb9-40aa-8796-068cf3075fc1.72d2abc3-aa69-4aeb-960b-6f6d25f498e4',
'thumbnail': 'https://store-images.s-microsoft.com/image/apps.24470.65457035095819016.56f55216-1bb9-40aa-8796-068cf3075fc1.72d2abc3-aa69-4aeb-960b-6f6d25f498e4',
'title': 'Screenshot',
}),
dict({
Expand All @@ -446,7 +446,7 @@
'media_class': <MediaClass.VIDEO: 'video'>,
'media_content_id': 'media-source://xbox/271958441785640/1297287135/game_media/17',
'media_content_type': <MediaClass.VIDEO: 'video'>,
'thumbnail': 'http://store-images.s-microsoft.com/image/apps.15604.65457035095819016.56f55216-1bb9-40aa-8796-068cf3075fc1.27cee011-660b-49a4-bd33-38db6fff5226',
'thumbnail': 'https://store-images.s-microsoft.com/image/apps.15604.65457035095819016.56f55216-1bb9-40aa-8796-068cf3075fc1.27cee011-660b-49a4-bd33-38db6fff5226',
'title': 'Screenshot',
}),
dict({
Expand All @@ -457,7 +457,7 @@
'media_class': <MediaClass.VIDEO: 'video'>,
'media_content_id': 'media-source://xbox/271958441785640/1297287135/game_media/18',
'media_content_type': <MediaClass.VIDEO: 'video'>,
'thumbnail': 'http://store-images.s-microsoft.com/image/apps.39987.65457035095819016.56f55216-1bb9-40aa-8796-068cf3075fc1.be285efe-78f8-4984-9d28-9159881bacd4',
'thumbnail': 'https://store-images.s-microsoft.com/image/apps.39987.65457035095819016.56f55216-1bb9-40aa-8796-068cf3075fc1.be285efe-78f8-4984-9d28-9159881bacd4',
'title': 'Screenshot',
}),
dict({
Expand All @@ -468,7 +468,7 @@
'media_class': <MediaClass.VIDEO: 'video'>,
'media_content_id': 'media-source://xbox/271958441785640/1297287135/game_media/19',
'media_content_type': <MediaClass.VIDEO: 'video'>,
'thumbnail': 'http://store-images.s-microsoft.com/image/apps.38206.65457035095819016.56f55216-1bb9-40aa-8796-068cf3075fc1.2409803d-7378-4a69-a10b-1574ac42b98b',
'thumbnail': 'https://store-images.s-microsoft.com/image/apps.38206.65457035095819016.56f55216-1bb9-40aa-8796-068cf3075fc1.2409803d-7378-4a69-a10b-1574ac42b98b',
'title': 'Screenshot',
}),
dict({
Expand All @@ -479,7 +479,7 @@
'media_class': <MediaClass.VIDEO: 'video'>,
'media_content_id': 'media-source://xbox/271958441785640/1297287135/game_media/20',
'media_content_type': <MediaClass.VIDEO: 'video'>,
'thumbnail': 'http://store-images.s-microsoft.com/image/apps.14938.65457035095819016.56f55216-1bb9-40aa-8796-068cf3075fc1.ef6ee72c-4beb-45ec-bd10-6235bd6a7c7f',
'thumbnail': 'https://store-images.s-microsoft.com/image/apps.14938.65457035095819016.56f55216-1bb9-40aa-8796-068cf3075fc1.ef6ee72c-4beb-45ec-bd10-6235bd6a7c7f',
'title': 'Screenshot',
}),
dict({
Expand All @@ -490,7 +490,7 @@
'media_class': <MediaClass.VIDEO: 'video'>,
'media_content_id': 'media-source://xbox/271958441785640/1297287135/game_media/21',
'media_content_type': <MediaClass.VIDEO: 'video'>,
'thumbnail': 'http://store-images.s-microsoft.com/image/apps.12835.65457035095819016.56f55216-1bb9-40aa-8796-068cf3075fc1.6165ee24-df01-44f5-80fe-7411f9366d1c',
'thumbnail': 'https://store-images.s-microsoft.com/image/apps.12835.65457035095819016.56f55216-1bb9-40aa-8796-068cf3075fc1.6165ee24-df01-44f5-80fe-7411f9366d1c',
'title': 'Screenshot',
}),
dict({
Expand All @@ -501,7 +501,7 @@
'media_class': <MediaClass.VIDEO: 'video'>,
'media_content_id': 'media-source://xbox/271958441785640/1297287135/game_media/22',
'media_content_type': <MediaClass.VIDEO: 'video'>,
'thumbnail': 'http://store-images.s-microsoft.com/image/apps.40786.65457035095819016.56f55216-1bb9-40aa-8796-068cf3075fc1.b7607a0d-0101-4864-9bf8-ad889f820489',
'thumbnail': 'https://store-images.s-microsoft.com/image/apps.40786.65457035095819016.56f55216-1bb9-40aa-8796-068cf3075fc1.b7607a0d-0101-4864-9bf8-ad889f820489',
'title': 'Screenshot',
}),
dict({
Expand All @@ -512,7 +512,7 @@
'media_class': <MediaClass.VIDEO: 'video'>,
'media_content_id': 'media-source://xbox/271958441785640/1297287135/game_media/23',
'media_content_type': <MediaClass.VIDEO: 'video'>,
'thumbnail': 'http://store-images.s-microsoft.com/image/apps.55686.65457035095819016.56f55216-1bb9-40aa-8796-068cf3075fc1.ecbb0e91-36a9-4f76-ab1e-5a5de009840e',
'thumbnail': 'https://store-images.s-microsoft.com/image/apps.55686.65457035095819016.56f55216-1bb9-40aa-8796-068cf3075fc1.ecbb0e91-36a9-4f76-ab1e-5a5de009840e',
'title': 'Screenshot',
}),
]),
Expand Down
Loading