Bump blinkpy to 0.25.1#158135
Conversation
|
Hey there @fronzbot, @mkmer, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
zweckj
left a comment
There was a problem hiding this comment.
please add a diff/link to the changes in the PR description and remember to fill out the PR template the next time, thanks
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Sorry for the template, I supposed it was not needed due to the lib version update. This is the compare between old version in manifest and new one: fronzbot/blinkpy@v0.24.1...v0.25.0 I just updated internal logic without change interfaces, so no updated needs on component side. I've tested it locally and it is now working. |
joostlek
left a comment
There was a problem hiding this comment.
This PR is now importing beautifulsoup. We don't allow that.
We only allow webscraping in the login flow, which from a quick view is what this is doing. However, we shouldn't use beautifulsoup for that. More info can be found here: https://github.com/home-assistant/architecture/blob/master/adr/0004-webscraping.md.
An example for how we do allow HTML parsing can be found here: https://github.com/tronikos/opower/blob/main/src/opower/utilities/smud.py
Ah ok. I did not know. So using HTMLParser is ok right? I'm updating the lib |
|
Yes! Thanks :) |
Hi, I've updated the library, this is the PR diff: https://github.com/fronzbot/blinkpy/pull/1155/files#diff-4d7c51b1efe9043e44439a949dfd92e5827321b34082903477fd04876edb7552 If ok I'll set the PR ready for review after library new version release |
|
That looks good I think! |
|
@KiraPC - Released |
Proposed change
fronzbot/blinkpy@v0.24.1...v0.25.1
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: