Skip to content

Improve Tuya HVACMode handling#158042

Merged
joostlek merged 3 commits into
devfrom
epenet-20251205-1455
Dec 9, 2025
Merged

Improve Tuya HVACMode handling#158042
joostlek merged 3 commits into
devfrom
epenet-20251205-1455

Conversation

@epenet
Copy link
Copy Markdown
Contributor

@epenet epenet commented Dec 5, 2025

Proposed change

Related to #157876 / #158258 / #158452

  • if the climate entity is missing both switch and mode wrapper, it now returns None (previously returned OFF)
  • if the climate entity has a mode wrapper, but the mode wrapper returns an invalid value (not present in enum), it now returns None (previously returned default switch_only_hvac_mode)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Dec 5, 2025

Hey there @tuya, @zlinoliver, mind taking a look at this pull request as it has been labeled with an integration (tuya) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of tuya can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign tuya Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

'last_reported': <ANY>,
'last_updated': <ANY>,
'state': 'off',
'state': 'unknown',
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5ls2jw49hpczwqng does not expose switch or mode wrapper.

'last_reported': <ANY>,
'last_updated': <ANY>,
'state': 'off',
'state': 'unknown',
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

B0eP8qYAdpUo4yR9 does not expose switch or mode wrapper.

'last_reported': <ANY>,
'last_updated': <ANY>,
'state': 'off',
'state': 'unknown',
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

d7woucobqi8ncacf does not expose switch or mode wrapper.

@epenet epenet added this to the 2025.12.3 milestone Dec 9, 2025
@epenet epenet marked this pull request as ready for review December 9, 2025 10:52
Copilot AI review requested due to automatic review settings December 9, 2025 10:52
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves HVAC mode handling for Tuya climate entities by returning None instead of OFF in cases where the device state is truly unknown. Previously, the integration would incorrectly return HVACMode.OFF for devices with no control mechanism (neither switch nor mode wrapper) or when the mode wrapper returned an invalid/unmapped value.

Key changes:

  • Returns None when both switch and mode wrappers are missing (instead of OFF)
  • Returns None when mode value doesn't map to a valid HVAC mode (instead of falling back to switch_only_hvac_mode)
  • Updates return type annotation to HVACMode | None to reflect the new behavior

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
homeassistant/components/tuya/climate.py Refactored hvac_mode property to properly return None for unknown states; updated return type to HVACMode | None; improved logic clarity by explicitly checking for None wrapper before reading status
tests/components/tuya/snapshots/test_climate.ambr Updated test snapshots for devices with no switch/mode wrappers - correctly changed state from 'off' to 'unknown' for three climate entities

Comment thread homeassistant/components/tuya/climate.py Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@joostlek joostlek merged commit bc031e7 into dev Dec 9, 2025
36 checks passed
@joostlek joostlek deleted the epenet-20251205-1455 branch December 9, 2025 20:18
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants