Enable name alias when sending a notification for google_mail#157927
Conversation
There was a problem hiding this comment.
Hi @hfehrmann
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
Hey there @tkdrob, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
|
Everything looks good, the error handling is a nice touch as this would allow for users that might be settings this up for the first time, or using this for the first time to better understand what they need to do. All tests so far have passed and just awaiting 3. This seems like a nice touch overall and allows for better communication. |
5f72926 to
291f153
Compare
|
@MS2620 Do I need to do something on my end here? I'm not sure why the pending checks are not running |
|
@hfehrmann Mind opening a PR to the documentation describing the new parameter? |
|
@joostlek Sure thing! I added PR for documentation change: home-assistant/home-assistant.io#42641 |
Proposed change
This change enables the possibility to define an alias that will appear as the sender name in the inbox of the receiver, instead of the email used to send the message
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: