Skip to content

Enable name alias when sending a notification for google_mail#157927

Merged
joostlek merged 4 commits into
home-assistant:devfrom
hfehrmann:google_mail/enable_sender_real_name
Dec 18, 2025
Merged

Enable name alias when sending a notification for google_mail#157927
joostlek merged 4 commits into
home-assistant:devfrom
hfehrmann:google_mail/enable_sender_real_name

Conversation

@hfehrmann
Copy link
Copy Markdown
Contributor

@hfehrmann hfehrmann commented Dec 4, 2025

Proposed change

This change enables the possibility to define an alias that will appear as the sender name in the inbox of the receiver, instead of the email used to send the message

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • [ x Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copy link
Copy Markdown
Contributor

@home-assistant home-assistant Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hfehrmann

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Dec 4, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Dec 4, 2025

Hey there @tkdrob, mind taking a look at this pull request as it has been labeled with an integration (google_mail) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of google_mail can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign google_mail Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@MS2620
Copy link
Copy Markdown

MS2620 commented Dec 7, 2025

Everything looks good, the error handling is a nice touch as this would allow for users that might be settings this up for the first time, or using this for the first time to better understand what they need to do. All tests so far have passed and just awaiting 3. This seems like a nice touch overall and allows for better communication.

@hfehrmann hfehrmann force-pushed the google_mail/enable_sender_real_name branch from 5f72926 to 291f153 Compare December 18, 2025 01:20
@hfehrmann
Copy link
Copy Markdown
Contributor Author

@MS2620 Do I need to do something on my end here? I'm not sure why the pending checks are not running

Comment thread homeassistant/components/google_mail/notify.py Outdated
Comment thread tests/components/google_mail/test_notify.py Outdated
@joostlek
Copy link
Copy Markdown
Member

@hfehrmann Mind opening a PR to the documentation describing the new parameter?

@hfehrmann
Copy link
Copy Markdown
Contributor Author

hfehrmann commented Dec 18, 2025

@joostlek Sure thing! I added PR for documentation change: home-assistant/home-assistant.io#42641

@joostlek joostlek merged commit 9e0a3de into home-assistant:dev Dec 18, 2025
36 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants