Skip to content

remove deep_sleep binary_sensor from fressnapf_tracker#157857

Merged
joostlek merged 1 commit into
home-assistant:devfrom
eifinger:fressnapf_tracker_remove_deep_sleep
Dec 3, 2025
Merged

remove deep_sleep binary_sensor from fressnapf_tracker#157857
joostlek merged 1 commit into
home-assistant:devfrom
eifinger:fressnapf_tracker_remove_deep_sleep

Conversation

@eifinger
Copy link
Copy Markdown
Contributor

@eifinger eifinger commented Dec 3, 2025

Proposed change

Old app versions are using deep sleep but the backend does not support this anymore.
It got replaced by energy_saving. The app still calls it "Sleep mode".

I will implement Sleep mode / energy saving in the switch platform.

Since this integration is not yet released I do not consider this a breaking change.

Sorry for the additional work.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the deprecated deep_sleep binary sensor from the fressnapf_tracker integration. The backend service no longer supports this field, and it will be replaced by an energy_saving feature in the switch platform. Since the integration hasn't been released yet, this is not considered a breaking change.

Key changes:

  • Removed deep_sleep binary sensor entity description from the binary_sensor platform
  • Cleaned up related translation strings
  • Updated test snapshots to reflect the removal

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
homeassistant/components/fressnapf_tracker/binary_sensor.py Removed the deprecated deep_sleep binary sensor entity description
homeassistant/components/fressnapf_tracker/strings.json Removed the deep_sleep translation key from the entity section
tests/components/fressnapf_tracker/snapshots/test_binary_sensor.ambr Removed snapshot test data for the deep_sleep binary sensor entity

@joostlek joostlek merged commit 5cff813 into home-assistant:dev Dec 3, 2025
41 of 42 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants