Add scene platform for Sunricher DALI integration#157808
Merged
joostlek merged 11 commits intoDec 18, 2025
Merged
Conversation
- Implement DaliCenterScene entity with activation support - Add parallel discovery of devices and scenes using asyncio.gather - Include entity ID mappings in scene attributes for related lights - Add comprehensive test coverage with fixtures and snapshots
- Implement DaliCenterScene entity with activation support - Add parallel discovery of devices and scenes using asyncio.gather - Include entity ID mappings in scene attributes for related lights - Add comprehensive test coverage with fixtures and snapshots
8 tasks
- Remove debug warning log in scene.py - Fix test_scene_read_failure to properly test exception handling during setup - Achieve 100% code coverage for scene platform
- Unify test data with DEVICE_DATA constant - Simplify mock device creation - Merge redundant test cases (9 → 5) - Maintain 100% test coverage
joostlek
requested changes
Dec 3, 2025
Contributor
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
joostlek
reviewed
Dec 4, 2025
- Remove isinstance check from DaliCenterEntity - Add DaliDeviceEntity for device-specific initialization - Update DaliCenterLight to use new base class
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
joostlek
approved these changes
Dec 18, 2025
Member
joostlek
left a comment
joostlek
left a comment
There was a problem hiding this comment.
I removed the entity id mapping for now so we can get this merged, feel free to open a new PR and we can discuss that change in that PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Add scene platform for Sunricher DALI integration
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: