Skip to content

Improve tests in WLED#157799

Merged
joostlek merged 2 commits into
home-assistant:devfrom
mik-laj:wled-tests
Dec 29, 2025
Merged

Improve tests in WLED#157799
joostlek merged 2 commits into
home-assistant:devfrom
mik-laj:wled-tests

Conversation

@mik-laj
Copy link
Copy Markdown
Contributor

@mik-laj mik-laj commented Dec 3, 2025

Breaking change

This PR address a few problem discussed in #155482

And besides that, it consolidated error handling tests using parametrization (config_flow, button, light)

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Dec 3, 2025

Hey there @frenck, mind taking a look at this pull request as it has been labeled with an integration (wled) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of wled can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign wled Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@mik-laj mik-laj marked this pull request as ready for review December 24, 2025 05:39
@mik-laj mik-laj requested a review from frenck as a code owner December 24, 2025 05:39
Copilot AI review requested due to automatic review settings December 24, 2025 05:39
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves test quality and coverage in the WLED integration by:

  • Migrating to snapshot-based testing across multiple platform test files
  • Using pytest.mark.parametrize to consolidate duplicate error handling tests
  • Replacing manual time mocking with the freezer fixture from freezegun
  • Adding platform override fixtures to ensure only relevant platforms are loaded during tests
  • Updating quality_scale.yaml to mark test coverage improvements as complete

Key Changes

  • Consolidated error handling tests using parametrization (config_flow, button, light)
  • Replaced verbose attribute assertions with snapshot comparisons
  • Added override_platforms fixtures to limit platform loading during tests
  • Updated coordinator tests to use freezer.tick() instead of dt_util.utcnow()

Reviewed changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.

Show a summary per file
File Description
test_update.py Added snapshot testing, platform override fixture, removed redundant assertions
test_switch.py Added snapshot test, platform override, removed duplicate state/entity/device assertions from behavior tests
test_sensor.py Converted to snapshot testing, added platform override, removed 100+ lines of manual assertions
test_select.py Added snapshot test, platform override fixture
test_number.py Added snapshot test, platform override fixture
test_light.py Added comprehensive snapshot tests, parametrized error tests to consolidate duplicates
test_button.py Added snapshot tests, parametrized error tests, separated device snapshot test
test_coordinator.py Replaced dt_util.utcnow() with freezer.tick() for time manipulation
test_config_flow.py Parametrized error tests, introduced CONFIG constant for reusability
quality_scale.yaml Marked config-flow-test-coverage and test-coverage as done
snapshots/*.ambr Added comprehensive snapshot files for all platforms

@joostlek joostlek merged commit bdb456e into home-assistant:dev Dec 29, 2025
41 of 42 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants