Improve tests in WLED#157799
Merged
Merged
Conversation
Contributor
|
Hey there @frenck, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves test quality and coverage in the WLED integration by:
- Migrating to snapshot-based testing across multiple platform test files
- Using
pytest.mark.parametrizeto consolidate duplicate error handling tests - Replacing manual time mocking with the
freezerfixture fromfreezegun - Adding platform override fixtures to ensure only relevant platforms are loaded during tests
- Updating quality_scale.yaml to mark test coverage improvements as complete
Key Changes
- Consolidated error handling tests using parametrization (config_flow, button, light)
- Replaced verbose attribute assertions with snapshot comparisons
- Added
override_platformsfixtures to limit platform loading during tests - Updated coordinator tests to use
freezer.tick()instead ofdt_util.utcnow()
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test_update.py | Added snapshot testing, platform override fixture, removed redundant assertions |
| test_switch.py | Added snapshot test, platform override, removed duplicate state/entity/device assertions from behavior tests |
| test_sensor.py | Converted to snapshot testing, added platform override, removed 100+ lines of manual assertions |
| test_select.py | Added snapshot test, platform override fixture |
| test_number.py | Added snapshot test, platform override fixture |
| test_light.py | Added comprehensive snapshot tests, parametrized error tests to consolidate duplicates |
| test_button.py | Added snapshot tests, parametrized error tests, separated device snapshot test |
| test_coordinator.py | Replaced dt_util.utcnow() with freezer.tick() for time manipulation |
| test_config_flow.py | Parametrized error tests, introduced CONFIG constant for reusability |
| quality_scale.yaml | Marked config-flow-test-coverage and test-coverage as done |
| snapshots/*.ambr | Added comprehensive snapshot files for all platforms |
joostlek
approved these changes
Dec 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
This PR address a few problem discussed in #155482
And besides that, it consolidated error handling tests using parametrization (config_flow, button, light)
Proposed change
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: