Pooldose: add number platform#157787
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a number platform to the Pooldose integration, enabling users to configure target values and overfeed alarm limits for pool chemistry parameters (pH, ORP, and chlorine). The implementation provides 9 configurable number entities that control the automatic dosing system.
Key Changes
- Added number platform with 3 target value entities and 6 overfeed alarm limit entities for pool chemistry control
- Implemented optimistic updates for immediate UI feedback when values are changed
- Comprehensive test coverage including snapshot tests, state changes, and unavailability scenarios
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| homeassistant/components/pooldose/init.py | Added Platform.NUMBER to PLATFORMS list to register the new number platform |
| homeassistant/components/pooldose/number.py | New implementation of number entities with coordinator-based updates and optimistic value setting |
| homeassistant/components/pooldose/strings.json | Added translation keys for all 9 number entities (targets and alarm limits) |
| homeassistant/components/pooldose/icons.json | Added appropriate icons for all 9 number entities |
| tests/components/pooldose/test_number.py | Comprehensive test suite covering entity creation, availability, state changes, value setting, and attributes |
| tests/components/pooldose/snapshots/test_number.ambr | Snapshot file containing expected entity registry and state data for all 9 number entities |
| tests/components/pooldose/fixtures/instantvalues.json | Added fixture data for all 9 number entities with appropriate value ranges and units |
joostlek
requested changes
Dec 2, 2025
Contributor
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
8 tasks
- use config category in number
joostlek
approved these changes
Dec 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Add number platform:
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: