Skip to content

Avoid exception when loading translation file for unloaded module #15765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
awarecan wants to merge 3 commits into from
Closed

Avoid exception when loading translation file for unloaded module #15765

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7231756
Avoid exception when loading translation file for unloaded module
awarecan Jul 31, 2018
d656077
Try to load component even it has been disabled during setup
awarecan Aug 2, 2018
24a6c5c
Fix typing
awarecan Aug 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions homeassistant/helpers/translation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@ def component_translation_file(hass, component, language):
name = component

module = get_component(hass, component)
if module is None:

@balloob balloob Aug 2, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes no sense. get_component is not about things not being setup. It's about loading the component from file, either from your custom components dir or from built-in.

@awarecan awarecan Aug 2, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, you are forcing me to fix the root cause. Got it.

_LOGGER.warning('component %s is not loaded', component)
return
component_path = path.dirname(module.__file__)

# If loading translations for the package root, (__init__.py), the
Expand Down
2 changes: 2 additions & 0 deletions homeassistant/util/json.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ def load_json(filename: str, default: Union[List, Dict, None] = None) \

Defaults to returning empty dict if file is not found.
"""
if filename is None:

@balloob balloob Aug 2, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also not good. We should fail. This code should never be called if filename is None.

We should write code that doesn't handle "bad" inputs and tries to fix them. Raise errors instead. The moment we fix them, that function will need to keep fixing it forever, even if other things get added to the function that would allow the previously bad input. The previously bad input expects to be "changed" or else bugs in other code happen.

return {}
try:
with open(filename, encoding='utf-8') as fdesc:
return json.loads(fdesc.read()) # type: ignore
Expand Down