Extract WebRTC integration#157648
Merged
balloob merged 8 commits intoDec 4, 2025
Merged
Conversation
![home-assistant[bot]](https://avatars.githubusercontent.com/in/97978?s=60&v=4){kind=small}
Contributor
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
|
Hey there @home-assistant/cloud, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
balloob
changed the title
balloob
force-pushed
the
claude/extract-webrtc-integration-01AHXVj6dh19FvgdL7rh439P
branch
from
c229dad to
c14b8fa
Compare
This was referenced Dec 1, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extracts WebRTC functionality from the camera component into a new standalone webrtc integration, making it available for use by other integrations. The extraction is part of standardization efforts and will be used by an upcoming PR.
Key changes:
- Created new WebRTC integration with ICE server registration and retrieval capabilities
- Updated camera and cloud components to use the new webrtc integration
- Comprehensive test coverage for the new integration
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| homeassistant/components/webrtc/init.py | New WebRTC integration with ICE server registration, retrieval, and WebSocket command handling |
| homeassistant/components/webrtc/manifest.json | Manifest for new WebRTC system integration with internal quality scale |
| tests/components/webrtc/init.py | Test package initialization for WebRTC integration |
| tests/components/webrtc/test_init.py | Comprehensive tests covering setup, custom ICE servers, registration, and WebSocket endpoints |
| homeassistant/components/camera/init.py | Updated to import async_get_ice_servers from webrtc integration and removed duplicate ICE server logic |
| homeassistant/components/camera/webrtc.py | Removed async_register_ice_servers function and DATA_ICE_SERVERS (moved to webrtc integration) |
| homeassistant/components/camera/manifest.json | Added webrtc as a dependency |
| homeassistant/components/cloud/client.py | Updated import to use async_register_ice_servers from webrtc integration |
| homeassistant/components/cloud/manifest.json | Added webrtc as a dependency |
| tests/components/camera/test_webrtc.py | Updated imports to use webrtc integration for ICE server functionality |
| script/hassfest/quality_scale.py | Added webrtc to quality scale exemptions list |
| script/hassfest/manifest.py | Added webrtc to non-scaled quality scale tiers |
| CODEOWNERS | Added codeowners entries for webrtc integration and tests |
Member
MartinHjelmare
left a comment
MartinHjelmare
left a comment
There was a problem hiding this comment.
I think @edenhaus should review too if there are more parts that should move, eg the client configuration and the WebRTC message classes.
balloob
force-pushed
the
claude/extract-webrtc-integration-01AHXVj6dh19FvgdL7rh439P
branch
from
d312778 to
ffca50a
Compare
This comment was marked as resolved.
This comment was marked as resolved.
edenhaus
reviewed
Dec 3, 2025
balloob
commented
Dec 3, 2025
edenhaus
approved these changes
Dec 3, 2025
Member
|
Fine to merge after merge conflict get resolved :) |
balloob
force-pushed
the
claude/extract-webrtc-integration-01AHXVj6dh19FvgdL7rh439P
branch
from
0483093 to
a294215
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
balloob
deleted the
claude/extract-webrtc-integration-01AHXVj6dh19FvgdL7rh439P
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Add WebRTC integration.
To standardize this and make available to other integrations.
Will be used for #157489
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: