Clarify percentage_command_topic and percentage_state_topic for MQTT fan#157460
Conversation
These aren't necessarily percentages; they're integers in the "speed range".
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
Hey there @emontnemery, @jbouwh, @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
|
I agree with the author that the documentation is not clear as it stands. It implies a percentage value will be received, but this is not the case. This is a small addition that will help clear this up for future users. |
jbouwh
left a comment
There was a problem hiding this comment.
We refer to the field names that are set via the UI.
Okay fair point. |
Co-authored-by: Jan Bouwhuis <jbouwh@users.noreply.github.com>
|
I opened home-assistant/home-assistant.io#42019 to align the online documentaion with this PR. |
Proposed change
The MQTT fan model is slightly confusing because the
percentage_state_topicandpercentage_command_topicvalues aren't actually percentages. This trivial documentation change just makes that a little bit clearer.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: