Skip to content

Pooldose: Add sensors for water meter#157382

Merged
joostlek merged 7 commits into
home-assistant:devfrom
lmaertin:pooldose-sensors-new
Dec 1, 2025
Merged

Pooldose: Add sensors for water meter#157382
joostlek merged 7 commits into
home-assistant:devfrom
lmaertin:pooldose-sensors-new

Conversation

@lmaertin
Copy link
Copy Markdown
Contributor

@lmaertin lmaertin commented Nov 26, 2025

Breaking change

Proposed change

  • Add sensors for water meter
  • Fixed duplicated flow_rate sensor
  • Adapted tests as well

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for water meter sensors to the Pooldose integration and fixes a unit handling issue that caused the flow_rate sensor to be duplicated. The changes enable users to track both permanent and resettable water meter readings from their Seko PoolDose devices.

Key Changes

  • Added two new water meter sensors: total (permanent) and resettable volume measurements
  • Fixed unit mapping to be case-insensitive by converting device units to uppercase before lookup
  • Updated test fixtures and snapshots to reflect the new sensors

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
homeassistant/components/pooldose/sensor.py Added two new sensor entity descriptions for water meters with VOLUME device class and dynamic unit handling; updated unit mapping to convert to uppercase
homeassistant/components/pooldose/const.py Updated UNIT_MAPPING dictionary to use uppercase keys and added volume unit mappings (L, M3)
homeassistant/components/pooldose/strings.json Added translation strings for the two new water meter sensors
homeassistant/components/pooldose/icons.json Added icon definitions (mdi:counter) for both water meter sensors
tests/components/pooldose/fixtures/instantvalues.json Added test data for water meter sensors and fixed flow_rate unit casing
tests/components/pooldose/snapshots/test_sensor.ambr Added snapshot entries for both new water meter sensor entities and their expected states

Comment thread homeassistant/components/pooldose/sensor.py
@zweckj zweckj marked this pull request as draft November 28, 2025 09:47
@lmaertin lmaertin marked this pull request as ready for review November 29, 2025 21:39
@joostlek joostlek merged commit fe85eaf into home-assistant:dev Dec 1, 2025
36 checks passed
@lmaertin lmaertin deleted the pooldose-sensors-new branch December 1, 2025 11:04
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants