Pooldose: Add sensors for water meter#157382
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for water meter sensors to the Pooldose integration and fixes a unit handling issue that caused the flow_rate sensor to be duplicated. The changes enable users to track both permanent and resettable water meter readings from their Seko PoolDose devices.
Key Changes
- Added two new water meter sensors: total (permanent) and resettable volume measurements
- Fixed unit mapping to be case-insensitive by converting device units to uppercase before lookup
- Updated test fixtures and snapshots to reflect the new sensors
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| homeassistant/components/pooldose/sensor.py | Added two new sensor entity descriptions for water meters with VOLUME device class and dynamic unit handling; updated unit mapping to convert to uppercase |
| homeassistant/components/pooldose/const.py | Updated UNIT_MAPPING dictionary to use uppercase keys and added volume unit mappings (L, M3) |
| homeassistant/components/pooldose/strings.json | Added translation strings for the two new water meter sensors |
| homeassistant/components/pooldose/icons.json | Added icon definitions (mdi:counter) for both water meter sensors |
| tests/components/pooldose/fixtures/instantvalues.json | Added test data for water meter sensors and fixed flow_rate unit casing |
| tests/components/pooldose/snapshots/test_sensor.ambr | Added snapshot entries for both new water meter sensor entities and their expected states |
zweckj
reviewed
Nov 27, 2025
…not be invoked by HA. It's better to define helpers for meters in HA directly.
joostlek
approved these changes
Dec 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: