Skip to content

Add support for switchbot presence sensor#157148

Closed
zerzhang wants to merge 1 commit into
home-assistant:devfrom
zerzhang:feature/presence_sensor
Closed

Add support for switchbot presence sensor#157148
zerzhang wants to merge 1 commit into
home-assistant:devfrom
zerzhang:feature/presence_sensor

Conversation

@zerzhang
Copy link
Copy Markdown
Contributor

@zerzhang zerzhang commented Nov 24, 2025 •
edited
Loading

Proposed change

  • Add presence sensor

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Nov 24, 2025

Hey there @Danielhiversen, @RenierM26, @murtas, @Eloston, @dsypniewski, mind taking a look at this pull request as it has been labeled with an integration (switchbot) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of switchbot can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign switchbot Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@zerzhang zerzhang mentioned this pull request Nov 24, 2025
Merged
8 tasks
@Misiu
Copy link
Copy Markdown
Contributor

Misiu commented Nov 24, 2025

There is an existing PR: #156314

@iz8mbw iz8mbw mentioned this pull request Nov 25, 2025
Merged
10 tasks
lukasmalkmus added a commit to lukasmalkmus/core that referenced this pull request Nov 25, 2025
@lukasmalkmus
homeassistant/components/switchbot: add battery_range sensor for pres…
b96dfbb 
…ence sensor

Presence sensors provide a battery_range field (e.g., '>=60%') in addition to
the numeric battery percentage. Add sensor entity description and translation
for this field.

Also update test to expect 4 sensors instead of 3 and verify the battery_range
sensor is created correctly.

Incorporates changes from PR home-assistant#157148.
joostlek
joostlek requested changes Nov 25, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So another PR now got merged. The only thing it lacks is the battery range. I don't mind having a discussion about that sensor, but like, we already have battery percentage for this device, what will a battery range add? I'd only add it if we find out that the device doesn't really work well with the battery percentage, but in that case we should remove the battery percentage and only expose the range.

But since getting this branch up to date probably takes more time, I am going to close it, but if you feel different about the battery entities, feel free to discuss :)

@home-assistant home-assistant Bot marked this pull request as draft November 25, 2025 14:19
@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Nov 25, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@joostlek joostlek closed this Nov 25, 2025
@iz8mbw
Copy link
Copy Markdown

iz8mbw commented Nov 25, 2025

thanks @joostlek

@github-actions github-actions Bot locked and limited conversation to collaborators Nov 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@joostlek joostlek joostlek requested changes

@Danielhiversen Danielhiversen Awaiting requested review from Danielhiversen Danielhiversen is a code owner

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

@Danielhiversen Danielhiversen

Labels

by-code-owner cla-signed has-tests integration: switchbot new-feature Quality Scale: gold small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zerzhang @Misiu @iz8mbw @joostlek @Danielhiversen