Upgrade Adafruit-DHT to 1.3.3#15706
Merged
balloob merged 4 commits intohome-assistant:devfrom Jul 30, 2018
superpuffin:patch-1
Merged
Upgrade Adafruit-DHT to 1.3.3#15706balloob merged 4 commits intohome-assistant:devfrom superpuffin:patch-1
balloob merged 4 commits intohome-assistant:devfrom
superpuffin:patch-1
Conversation
The package Adafruit_Python_DHT==1.3.2 was broken and would not install, breaking DHT sensor support in Home assistant. It has since been fixed in Adafruit-DHT==1.3.3. See: adafruit/Adafruit_Python_DHT#99
Contributor
|
Hi @superpuffin, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
fabaff
requested changes
Jul 27, 2018
Member
fabaff
left a comment
There was a problem hiding this comment.
See checklist:
- New or updated dependencies have been added to
requirements_all.txtby runningscript/gen_requirements_all.py.
New or updated dependencies have been added to `requirements_all.txt` by running `script/gen_requirements_all.py`.
8 tasks
Adafruit_Python_DHT changed name to Adafruit-DHT, which still need pyx support breaking our CI, need to be comment out.
Member
|
After this is merged, we need add the changes also to Hass.io |
Contributor
|
@fabaff will you approve this? |
balloob
approved these changes
Jul 30, 2018
michaeldavie
pushed a commit
to michaeldavie/home-assistant
that referenced
this pull request
Jul 31, 2018
* Change to newer pip package The package Adafruit_Python_DHT==1.3.2 was broken and would not install, breaking DHT sensor support in Home assistant. It has since been fixed in Adafruit-DHT==1.3.3. See: adafruit/Adafruit_Python_DHT#99 * Update requirements_all.txt New or updated dependencies have been added to `requirements_all.txt` by running `script/gen_requirements_all.py`. * Comment out Adafruit-DHT Adafruit_Python_DHT changed name to Adafruit-DHT, which still need pyx support breaking our CI, need to be comment out. * Update requirements_all.txt
|
So is this fix included in 0.75? If not, is there any way to run dev on hassOS to have the fix included / to test it? Thanks in advance |
Contributor
|
Not in 0.75, it missed train. hassOS/hass.io problem please ask in forum or discord, not under this PR. |
balloob
pushed a commit
that referenced
this pull request
Aug 4, 2018
* Change to newer pip package The package Adafruit_Python_DHT==1.3.2 was broken and would not install, breaking DHT sensor support in Home assistant. It has since been fixed in Adafruit-DHT==1.3.3. See: adafruit/Adafruit_Python_DHT#99 * Update requirements_all.txt New or updated dependencies have been added to `requirements_all.txt` by running `script/gen_requirements_all.py`. * Comment out Adafruit-DHT Adafruit_Python_DHT changed name to Adafruit-DHT, which still need pyx support breaking our CI, need to be comment out. * Update requirements_all.txt
Merged
|
Buongirno, I return these errors, how do I solve? my config |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The package Adafruit_Python_DHT==1.3.2 was broken and would not install, breaking DHT sensor support in Home assistant. It has since been fixed in Adafruit-DHT==1.3.3.
See: adafruit/Adafruit_Python_DHT#99
Description:
Related issue (if applicable): fixes #
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: