Fix Min/Max Kelvin color temp attribute for Google#15697
Merged
balloob merged 3 commits intohome-assistant:devfrom Aug 2, 2018
Merged
Fix Min/Max Kelvin color temp attribute for Google#15697balloob merged 3 commits intohome-assistant:devfrom
balloob merged 3 commits intohome-assistant:devfrom
Conversation
Max Kelvin is actually Min Mireds and vice-versa. K = 1000000 / mireds
homeassistant
added
integration: google_assistant
core
small-pr
ghost
added
the
Contributor
Author
|
@balloob Since you wrote the refactor, you might be the best person to review this? |
balloob
approved these changes
Aug 2, 2018
Member
|
Thanks! |
balloob
pushed a commit
that referenced
this pull request
Aug 3, 2018
* Fix Min/Max Kelvin color temp attribute for Google Max Kelvin is actually Min Mireds and vice-versa. K = 1000000 / mireds * Update test_smart_home.py * Update test_trait.py
Merged
|
In my Home Assistant / Google Assistant setup, the color temperature still seems to be reversed. i.e. asking Google to set the lights to "daylight" or "soft white" results in warm/soft white, whereas asking it to set the lights to "candlelight" results in cool white. I'm using 0.76.2. |
Contributor
Author
|
@duffrecords You should probably open an issue as merged PR's aren't a method of support. However please try unlinking and relinking the skill. Had to do that for this change to take effect |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Max Kelvin is actually Min Mireds and vice-versa. K = 1000000 / mireds
Description:
When the refactor for google_assistant and some additional color_util changes were done, there was an oversight in the reported Kelvin attribute for Google Assistant. The maximum kelvin is actually the minimum mireds and vice-versa. This caused the color temperature for white to skew towards super warm when utilizing Google Assistant. This PR fixes this.
Related issue (if applicable): fixes #14364
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: