Bump pySmartThings to 3.3.4#156830
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR bumps the pySmartThings dependency from version 3.3.3 to 3.3.4 for the SmartThings integration, categorized as a bugfix.
- Updates pySmartThings library version across all dependency files
- Maintains consistent version pinning at 3.3.4
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| requirements_test_all.txt | Updates pysmartthings test dependency to 3.3.4 |
| requirements_all.txt | Updates pysmartthings production dependency to 3.3.4 |
| homeassistant/components/smartthings/manifest.json | Updates requirements field to specify pysmartthings==3.3.4 |
| "loggers": ["pysmartthings"], | ||
| "quality_scale": "bronze", | ||
| "requirements": ["pysmartthings==3.3.3"] | ||
| "requirements": ["pysmartthings==3.3.4"] |
There was a problem hiding this comment.
The PR description indicates this is a dependency upgrade for a bugfix, but lacks the required changelog link or version diff as specified in the PR template: 'For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.' Please add a link to the pySmartThings changelog or a diff showing what changed between versions 3.3.3 and 3.3.4 to help reviewers understand what bug is being fixed.
zweckj
left a comment
There was a problem hiding this comment.
please add the changelog/diff to the description
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
TheJulianJES
left a comment
There was a problem hiding this comment.
Changelog/diff is added. Changes look good to me.
|
Ho, thanks for adding |
Proposed change
Bump pySmartThings to 3.3.4: pySmartThings/pysmartthings@v3.3.3...v3.3.4
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: