Skip to content

Support UniFi LED control for devices without RGB#156812

Merged
Kane610 merged 7 commits into
home-assistant:devfrom
Sese-Schneider:led-control-no-rgb
Nov 28, 2025
Merged

Support UniFi LED control for devices without RGB#156812
Kane610 merged 7 commits into
home-assistant:devfrom
Sese-Schneider:led-control-no-rgb

Conversation

@Sese-Schneider
Copy link
Copy Markdown
Contributor

Proposed change

Introduces conditional control for UniFi network devices which do not support RGB, but only have ON/OFF capabilities.

I've analyzed the obfuscated frontend JS source code of the UniFi controller, however there seems to be no flag related to general LED support.
For future reference I created a Gist with all the Flags: https://gist.github.com/Sese-Schneider/f176e2c801371317522d8943becb19f6 (cc @Kane610)

Based on my understanding of the source code the LED component is shown if the device has the attribute led_override.
I chose the same condition to enable ON/OFF LED control.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @Kane610, mind taking a look at this pull request as it has been labeled with an integration (unifi) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of unifi can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign unifi Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for UniFi LED control on devices that only support ON/OFF functionality without RGB capabilities. The implementation differentiates between devices with full LED ring support (RGB + brightness) and devices with basic LED control (ON/OFF only) by checking hardware capabilities.

Key changes:

  • Modified device support detection to include devices with led_override attribute
  • Implemented conditional color mode selection based on supports_led_ring capability
  • Added helper functions for brightness conversion and default value handling

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
homeassistant/components/unifi/light.py Core logic changes to support both RGB and ON/OFF LED modes with conditional attribute handling
tests/components/unifi/test_light.py Added comprehensive test coverage for ON/OFF-only devices and mode differentiation

Comment thread homeassistant/components/unifi/light.py
Comment thread homeassistant/components/unifi/light.py
Comment thread homeassistant/components/unifi/light.py
Comment thread homeassistant/components/unifi/light.py Outdated
@Kane610
Copy link
Copy Markdown
Member

Kane610 commented Nov 19, 2025

aiounifi v88 has been released

@Sese-Schneider
Copy link
Copy Markdown
Contributor Author

@Kane610 I've opened a new PR to bump the aiounifi version: #156867
This PR adresses a different issue: #155880
I still think its worth releasing this in the next fix version of HA as it "fixes" this issues.

@Sese-Schneider
Copy link
Copy Markdown
Contributor Author

@Kane610 could you leave a review please so this PR can be considered for 2025.12? Much appreciated 🤗

@Kane610 Kane610 added this to the 2025.12.0 milestone Nov 28, 2025
Copy link
Copy Markdown
Member

@Kane610 Kane610 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@Kane610 Kane610 merged commit 8c8708d into home-assistant:dev Nov 28, 2025
35 of 36 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unifi Network LED toggle not appearing

5 participants