Skip to content

Fix blocking call in cync#156782

Merged
joostlek merged 2 commits into
devfrom
epenet-20251118-0813
Nov 18, 2025
Merged

Fix blocking call in cync#156782
joostlek merged 2 commits into
devfrom
epenet-20251118-0813

Conversation

@epenet
Copy link
Copy Markdown
Contributor

@epenet epenet commented Nov 18, 2025

Proposed change

Fixes #156762

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes blocking call to load_default_certs #156762
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @Kinachi249, mind taking a look at this pull request as it has been labeled with an integration (cync) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of cync can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign cync Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@epenet epenet added this to the 2025.11.3 milestone Nov 18, 2025
@epenet epenet changed the title Fix block call in cync Fix blocking call in cync Nov 18, 2025
@epenet epenet marked this pull request as ready for review November 18, 2025 09:37
Copilot AI review requested due to automatic review settings November 18, 2025 09:37
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a blocking call issue in the Cync integration by passing an SSL context to the Cync.create() method. The fix prevents the pycync library from creating its own SSL context (which involves blocking operations) by providing a pre-configured, cached context from Home Assistant's utility functions.

Key changes:

  • Import get_default_context from homeassistant.util.ssl
  • Create and pass ssl_context parameter to Cync.create() to avoid blocking SSL context creation in the library

@joostlek joostlek merged commit bd87119 into dev Nov 18, 2025
41 of 42 checks passed
@joostlek joostlek deleted the epenet-20251118-0813 branch November 18, 2025 10:41
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

blocking call to load_default_certs

4 participants