Skip to content

Fix is_matching in samsungtv config flow#156594

Merged
epenet merged 8 commits into
home-assistant:devfrom
FredrikM97:Initialize_host_with_None_to_prevent_reconfigure_error
Nov 18, 2025
Merged

Fix is_matching in samsungtv config flow#156594
epenet merged 8 commits into
home-assistant:devfrom
FredrikM97:Initialize_host_with_None_to_prevent_reconfigure_error

Conversation

@FredrikM97
Copy link
Copy Markdown
Contributor

@FredrikM97 FredrikM97 commented Nov 14, 2025

Proposed change

Prevent missing _host property for samsungtv

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes SamsungTVConfigFlow #156591
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @chemelli74, @epenet, mind taking a look at this pull request as it has been labeled with an integration (samsungtv) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of samsungtv can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign samsungtv Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Comment thread homeassistant/components/samsungtv/config_flow.py Outdated
@epenet epenet added this to the 2025.11.2 milestone Nov 14, 2025
@epenet epenet marked this pull request as draft November 14, 2025 14:31
@FredrikM97 FredrikM97 marked this pull request as ready for review November 14, 2025 15:39
@FredrikM97 FredrikM97 changed the title Initialize host with none to prevent reconfigure error Samsungtv: Check if is_matching attribute _host exists Nov 14, 2025
Comment thread tests/components/samsungtv/test_config_flow.py Outdated
@frenck frenck modified the milestones: 2025.11.2, 2025.11.3 Nov 14, 2025
Comment thread tests/components/samsungtv/test_config_flow.py Outdated
Copy link
Copy Markdown
Contributor

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@epenet epenet changed the title Samsungtv: Check if is_matching attribute _host exists Fix is_matching in samsungtv config flow Nov 17, 2025
Comment thread tests/components/samsungtv/test_config_flow.py Outdated
Comment thread tests/components/samsungtv/test_config_flow.py
Copy link
Copy Markdown
Contributor

@chemelli74 chemelli74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx !

@epenet epenet merged commit 291331f into home-assistant:dev Nov 18, 2025
36 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SamsungTVConfigFlow

4 participants