Skip to content

Import collections abstract base classes from collections.abc #15649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
balloob merged 1 commit into from
Jul 25, 2018
Merged

Import collections abstract base classes from collections.abc #15649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions homeassistant/components/google_assistant/smart_home.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
"""Support for Google Assistant Smart Home API."""
import collections
from collections.abc import Mapping
from itertools import product
import logging

Expand Down Expand Up @@ -50,7 +50,7 @@
def deep_update(target, source):
"""Update a nested dictionary with another nested dictionary."""
for key, value in source.items():
if isinstance(value, collections.Mapping):
if isinstance(value, Mapping):
target[key] = deep_update(target.get(key, {}), value)
else:
target[key] = value
Expand Down
4 changes: 2 additions & 2 deletions homeassistant/components/notify/group.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
https://home-assistant.io/components/notify.group/
"""
import asyncio
import collections
from collections.abc import Mapping
from copy import deepcopy
import logging
import voluptuous as vol
Expand Down Expand Up @@ -33,7 +33,7 @@ def update(input_dict, update_source):
Async friendly.
"""
for key, val in update_source.items():
if isinstance(val, collections.Mapping):
if isinstance(val, Mapping):
recurse = update(input_dict.get(key, {}), val)
input_dict[key] = recurse
else:
Expand Down