Skip to content

Add HomematicIP Cloud smoke detector device #15621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
balloob merged 2 commits into from
Aug 9, 2018
Merged

Add HomematicIP Cloud smoke detector device #15621

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ffa4ea
Add smoke detector device
worm-ee Jul 22, 2018
50fbedd
Remove not needed __init__ functions
worm-ee Jul 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 21 additions & 15 deletions homeassistant/components/binary_sensor/homematicip_cloud.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,7 @@

_LOGGER = logging.getLogger(__name__)

ATTR_WINDOW_STATE = 'window_state'
ATTR_EVENT_DELAY = 'event_delay'
ATTR_MOTION_DETECTED = 'motion_detected'
ATTR_ILLUMINATION = 'illumination'
STATE_SMOKE_OFF = 'IDLE_OFF'


async def async_setup_platform(hass, config, async_add_devices,
Expand All @@ -30,15 +27,18 @@ async def async_setup_platform(hass, config, async_add_devices,

async def async_setup_entry(hass, config_entry, async_add_devices):
"""Set up the HomematicIP binary sensor from a config entry."""
from homematicip.device import (ShutterContact, MotionDetectorIndoor)
from homematicip.aio.device import (
AsyncShutterContact, AsyncMotionDetectorIndoor, AsyncSmokeDetector)

home = hass.data[HMIPC_DOMAIN][config_entry.data[HMIPC_HAPID]].home
devices = []
for device in home.devices:
if isinstance(device, ShutterContact):
if isinstance(device, AsyncShutterContact):
devices.append(HomematicipShutterContact(home, device))
elif isinstance(device, MotionDetectorIndoor):
elif isinstance(device, AsyncMotionDetectorIndoor):
devices.append(HomematicipMotionDetector(home, device))
elif isinstance(device, AsyncSmokeDetector):
devices.append(HomematicipSmokeDetector(home, device))

if devices:
async_add_devices(devices)
Expand All @@ -47,10 +47,6 @@ async def async_setup_entry(hass, config_entry, async_add_devices):
class HomematicipShutterContact(HomematicipGenericDevice, BinarySensorDevice):
"""HomematicIP shutter contact."""

def __init__(self, home, device):
"""Initialize the shutter contact."""
super().__init__(home, device)

@property
def device_class(self):
"""Return the class of this sensor."""
Expand All @@ -71,10 +67,6 @@ def is_on(self):
class HomematicipMotionDetector(HomematicipGenericDevice, BinarySensorDevice):
"""MomematicIP motion detector."""

def __init__(self, home, device):
"""Initialize the shutter contact."""
super().__init__(home, device)

@property
def device_class(self):
"""Return the class of this sensor."""
Expand All @@ -86,3 +78,17 @@ def is_on(self):
if self._device.sabotage:
return True
return self._device.motionDetected


class HomematicipSmokeDetector(HomematicipGenericDevice, BinarySensorDevice):
"""MomematicIP smoke detector."""
Copy link
Copy Markdown

@BudBundi BudBundi Aug 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little typo there? MomematicIP


@property
def device_class(self):
"""Return the class of this sensor."""
return 'smoke'

@property
def is_on(self):
"""Return true if smoke is detected."""
return self._device.smokeDetectorAlarmType != STATE_SMOKE_OFF