Skip to content

Music Assistant: Fix strings.json#156188

Merged
arturpragacz merged 8 commits into
home-assistant:devfrom
OzGav:ma-strings-json
Nov 10, 2025
Merged

Music Assistant: Fix strings.json#156188
arturpragacz merged 8 commits into
home-assistant:devfrom
OzGav:ma-strings-json

Conversation

@OzGav
Copy link
Copy Markdown
Contributor

@OzGav OzGav commented Nov 9, 2025

Proposed change

Changes in support of the Music Assistant Bronze Quality Level application

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Nov 9, 2025

Hey there @music-assistant, mind taking a look at this pull request as it has been labeled with an integration (music_assistant) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of music_assistant can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign music_assistant Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

zweckj
zweckj previously requested changes Nov 9, 2025
Comment thread homeassistant/components/music_assistant/strings.json
Comment thread homeassistant/components/music_assistant/strings.json
@home-assistant home-assistant Bot marked this pull request as draft November 9, 2025 13:54
@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Nov 9, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@OzGav OzGav marked this pull request as ready for review November 10, 2025 02:24
@home-assistant home-assistant Bot requested a review from zweckj November 10, 2025 02:24
@OzGav OzGav requested a review from arturpragacz November 10, 2025 02:24
Comment thread homeassistant/components/music_assistant/strings.json Outdated
Comment thread homeassistant/components/music_assistant/strings.json Outdated
Comment thread homeassistant/components/music_assistant/strings.json Outdated
@home-assistant home-assistant Bot marked this pull request as draft November 10, 2025 03:41
OzGav and others added 3 commits November 10, 2025 15:03
Co-authored-by: Artur Pragacz <49985303+arturpragacz@users.noreply.github.com>
Co-authored-by: Artur Pragacz <49985303+arturpragacz@users.noreply.github.com>
Co-authored-by: Artur Pragacz <49985303+arturpragacz@users.noreply.github.com>
@OzGav OzGav marked this pull request as ready for review November 10, 2025 04:08
@arturpragacz arturpragacz dismissed zweckj’s stale review November 10, 2025 04:34

Comments addressed

@arturpragacz arturpragacz merged commit dbc53b9 into home-assistant:dev Nov 10, 2025
36 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants