Migrate friends to subentries in Xbox integration#156101
Merged
Merged
Conversation
Contributor
|
Hey there @hunterjm, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
4fd47b3 to
4b9e1e8
Compare
joostlek
requested changes
Nov 10, 2025
Contributor
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
bbb3d67 to
0d17196
Compare
0d17196 to
bc59d82
Compare
bc59d82 to
34f1400
Compare
joostlek
reviewed
Dec 4, 2025
4167fa1 to
6e628b4
Compare
Merged
8 tasks
6e628b4 to
d7c902a
Compare
joostlek
approved these changes
Dec 16, 2025
heindrichpaul
pushed a commit
to heindrichpaul/core
that referenced
this pull request
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Currently, adding friends to the Xbox integration is handled by marking them as favorites in the Xbox Network. However, since the integration was recently expanded to support multiple Xbox accounts, this approach can lead to unique ID conflicts when a person is a friend of more than one account. In such cases, each integration instance may attempt to create entities for the same friend, and which one succeeds depends on the order in which the integrations are loaded.
By migrating from favorites to sub-entries, we gain finer control over which integration entry is responsible for creating entities for a given friend.
To avoid breaking existing setups, a config entry migration will run once and automatically create sub-entries for each friend currently marked as a favorite.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: