Skip to content

Migrate friends to subentries in Xbox integration#156101

Merged
joostlek merged 5 commits into
home-assistant:devfrom
tr4nt0r:xbox_subentries
Dec 16, 2025
Merged

Migrate friends to subentries in Xbox integration#156101
joostlek merged 5 commits into
home-assistant:devfrom
tr4nt0r:xbox_subentries

Conversation

@tr4nt0r
Copy link
Copy Markdown
Contributor

@tr4nt0r tr4nt0r commented Nov 8, 2025

Proposed change

Currently, adding friends to the Xbox integration is handled by marking them as favorites in the Xbox Network. However, since the integration was recently expanded to support multiple Xbox accounts, this approach can lead to unique ID conflicts when a person is a friend of more than one account. In such cases, each integration instance may attempt to create entities for the same friend, and which one succeeds depends on the order in which the integrations are loaded.

By migrating from favorites to sub-entries, we gain finer control over which integration entry is responsible for creating entities for a given friend.

To avoid breaking existing setups, a config entry migration will run once and automatically create sub-entries for each friend currently marked as a favorite.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Nov 8, 2025

Hey there @hunterjm, mind taking a look at this pull request as it has been labeled with an integration (xbox) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of xbox can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign xbox Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Comment thread homeassistant/components/xbox/coordinator.py Outdated
Comment thread homeassistant/components/xbox/coordinator.py Outdated
@home-assistant
Copy link
Copy Markdown
Contributor

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant Bot marked this pull request as draft November 10, 2025 15:46
@tr4nt0r tr4nt0r marked this pull request as ready for review November 10, 2025 16:00
@home-assistant home-assistant Bot requested a review from joostlek November 10, 2025 16:00
@tr4nt0r tr4nt0r marked this pull request as draft November 12, 2025 12:56
@tr4nt0r tr4nt0r marked this pull request as ready for review November 12, 2025 13:40
@tr4nt0r tr4nt0r marked this pull request as draft November 22, 2025 16:59
@tr4nt0r tr4nt0r marked this pull request as ready for review November 22, 2025 17:25
Comment thread homeassistant/components/xbox/__init__.py Outdated
Comment thread homeassistant/components/xbox/binary_sensor.py
@tr4nt0r tr4nt0r marked this pull request as draft December 4, 2025 14:01
@tr4nt0r tr4nt0r marked this pull request as ready for review December 5, 2025 16:33
@home-assistant home-assistant Bot requested a review from joostlek December 5, 2025 16:33
@joostlek joostlek merged commit 7b1653c into home-assistant:dev Dec 16, 2025
36 checks passed
@tr4nt0r tr4nt0r deleted the xbox_subentries branch December 16, 2025 15:22
heindrichpaul pushed a commit to heindrichpaul/core that referenced this pull request Dec 17, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants