Skip to content

Register music assistant services in async setup#155963

Merged
joostlek merged 1 commit into
home-assistant:devfrom
arturpragacz:music_assistant/register-services-in-async-setup
Nov 18, 2025
Merged

Register music assistant services in async setup#155963
joostlek merged 1 commit into
home-assistant:devfrom
arturpragacz:music_assistant/register-services-in-async-setup

Conversation

@arturpragacz
Copy link
Copy Markdown
Member

Proposed change

Register music assistant services in async setup.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Nov 6, 2025

Hey there @music-assistant, mind taking a look at this pull request as it has been labeled with an integration (music_assistant) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of music_assistant can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign music_assistant Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the Music Assistant integration by centralizing service-related code and improving code organization. The changes move platform entity service registrations from the media player module to a dedicated services module, and extract a reusable helper function into a separate helpers module.

  • Centralized service definitions and registrations in services.py
  • Extracted get_music_assistant_client helper to helpers.py for better code organization
  • Updated imports across all affected files to reflect the new structure

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
homeassistant/components/music_assistant/services.py Added platform entity service registrations (play_media, play_announcement, transfer_queue, get_queue) and imported necessary constants; imported get_music_assistant_client from helpers module
homeassistant/components/music_assistant/media_player.py Removed platform entity service registrations and related imports that were moved to services.py; removed unused service constant definitions
homeassistant/components/music_assistant/helpers.py Added get_music_assistant_client helper function moved from services.py with proper imports and type checking
homeassistant/components/music_assistant/init.py Updated import to get get_music_assistant_client from helpers module instead of services module
tests/components/music_assistant/test_media_player.py Updated imports to get service constants from services module instead of media_player module

@joostlek joostlek merged commit c32a471 into home-assistant:dev Nov 18, 2025
41 of 42 checks passed
@arturpragacz arturpragacz deleted the music_assistant/register-services-in-async-setup branch November 18, 2025 11:17
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants