Register music assistant services in async setup#155963
Merged
joostlek merged 1 commit intoNov 18, 2025
Merged
Conversation
Contributor
|
Hey there @music-assistant, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
39 tasks
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the Music Assistant integration by centralizing service-related code and improving code organization. The changes move platform entity service registrations from the media player module to a dedicated services module, and extract a reusable helper function into a separate helpers module.
- Centralized service definitions and registrations in
services.py - Extracted
get_music_assistant_clienthelper tohelpers.pyfor better code organization - Updated imports across all affected files to reflect the new structure
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| homeassistant/components/music_assistant/services.py | Added platform entity service registrations (play_media, play_announcement, transfer_queue, get_queue) and imported necessary constants; imported get_music_assistant_client from helpers module |
| homeassistant/components/music_assistant/media_player.py | Removed platform entity service registrations and related imports that were moved to services.py; removed unused service constant definitions |
| homeassistant/components/music_assistant/helpers.py | Added get_music_assistant_client helper function moved from services.py with proper imports and type checking |
| homeassistant/components/music_assistant/init.py | Updated import to get get_music_assistant_client from helpers module instead of services module |
| tests/components/music_assistant/test_media_player.py | Updated imports to get service constants from services module instead of media_player module |
joostlek
approved these changes
Nov 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Register music assistant services in async setup.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: