Fix args passed to check_config script#155885
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the check_config script to handle cases where script_args is an empty list by falling back to parsing all CLI arguments. The change is intended to support out-of-order argument scenarios where arguments passed to the main Home Assistant command might not be properly forwarded to the script.
- Updates argument parsing logic to use
script_args or Noneinstead of justscript_args - Adds explanatory comments describing the out-of-order argument scenario
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Co-authored-by: Johann Kellerman <kellerza@gmail.com>
|
You will have to fix all tests that uses the
|
Working on that right now. |
|
Thanks @tmonck ! |
Breaking change
Proposed change
Continue to allow args passed in any order for the script check_config.
Type of change
Additional information
Related to the #152575 as that is where the passing of
script_argswas introduced.Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: