Skip to content

Add Reolink audio noise reduction number entity#155757

Merged
abmantis merged 6 commits into
home-assistant:devfrom
starkillerOG:reolink_noise
Nov 3, 2025
Merged

Add Reolink audio noise reduction number entity#155757
abmantis merged 6 commits into
home-assistant:devfrom
starkillerOG:reolink_noise

Conversation

@starkillerOG
Copy link
Copy Markdown
Contributor

@starkillerOG starkillerOG commented Nov 3, 2025

Breaking change

Proposed change

Add Reolink audio noise reduction number entity
0 = no noise reduction
5 = highest level of noise reduction

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new "Audio noise reduction" number entity for Reolink cameras that allows users to control the audio noise reduction level from 0 to 5.

Key Changes

  • Adds a new noise_reduction number entity with configurable values 0-5
  • Includes translation strings and state-based icons
  • Entity is disabled by default and uses the Baichuan API methods for get/set operations

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
homeassistant/components/reolink/number.py Adds new noise_reduction number entity description with cmd_key "439" and baichuan API methods
homeassistant/components/reolink/strings.json Adds translation key "noise_reduction" with name "Audio noise reduction"
homeassistant/components/reolink/icons.json Defines icons for noise reduction entity with state-based icon for value 0

Comment thread homeassistant/components/reolink/number.py Outdated
Comment thread homeassistant/components/reolink/strings.json Outdated
Copy link
Copy Markdown
Member

@abmantis abmantis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are now conflicts from the other merged PR

@home-assistant home-assistant Bot marked this pull request as draft November 3, 2025 21:57
@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Nov 3, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

starkillerOG and others added 4 commits November 3, 2025 23:02
Co-authored-by: Abílio Costa <abmantis@users.noreply.github.com>
@starkillerOG starkillerOG marked this pull request as ready for review November 3, 2025 22:23
@home-assistant home-assistant Bot requested a review from abmantis November 3, 2025 22:23
Copy link
Copy Markdown
Member

@abmantis abmantis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@abmantis abmantis merged commit ab6d4d6 into home-assistant:dev Nov 3, 2025
36 checks passed
@starkillerOG starkillerOG deleted the reolink_noise branch November 3, 2025 23:11
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants