Skip to content

Use data_description in config_flow for GIOS#155605

Merged
bieniu merged 5 commits into
home-assistant:devfrom
mik-laj:gios-fix-1
Nov 1, 2025
Merged

Use data_description in config_flow for GIOS#155605
bieniu merged 5 commits into
home-assistant:devfrom
mik-laj:gios-fix-1

Conversation

@mik-laj
Copy link
Copy Markdown
Contributor

@mik-laj mik-laj commented Nov 1, 2025

Breaking change

Proposed change

Part of: #155603

This PR adds a data_description field to the GIOS integration's config flow to provide helpful context to users during the configuration process.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copilot AI review requested due to automatic review settings November 1, 2025 13:26
@mik-laj mik-laj requested a review from bieniu as a code owner November 1, 2025 13:26
@home-assistant home-assistant Bot added cla-signed integration: gios small-pr PRs with less than 30 lines. labels Nov 1, 2025
@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Nov 1, 2025

Hey there @bieniu, mind taking a look at this pull request as it has been labeled with an integration (gios) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of gios can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign gios Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a data_description field to the GIOS integration's config flow to provide helpful context to users about the station_id field during the configuration process.

@mik-laj mik-laj changed the title Use data_description in config_flow for WLED Use data_description in config_flow for GIOS Nov 1, 2025
@mik-laj mik-laj requested a review from Copilot November 1, 2025 13:35
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

Comment thread homeassistant/components/gios/strings.json Outdated
Comment thread homeassistant/components/gios/strings.json
Comment thread homeassistant/components/gios/strings.json Outdated
mik-laj and others added 2 commits November 1, 2025 16:15
Co-authored-by: Maciej Bieniek <bieniu@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Comment thread homeassistant/components/gios/strings.json Outdated
@home-assistant home-assistant Bot marked this pull request as draft November 1, 2025 15:28
@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Nov 1, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Comment thread homeassistant/components/gios/strings.json Outdated
@mik-laj mik-laj requested a review from bieniu November 1, 2025 15:31
@mik-laj mik-laj marked this pull request as ready for review November 1, 2025 15:35
@bieniu bieniu merged commit 09d78ab into home-assistant:dev Nov 1, 2025
36 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants