Skip to content

Add auto empty sensor to Ecovacs#155489

Merged
edenhaus merged 3 commits into
home-assistant:devfrom
aronnebrivio:feat/ecovacs-missing-functionalities
Oct 31, 2025
Merged

Add auto empty sensor to Ecovacs#155489
edenhaus merged 3 commits into
home-assistant:devfrom
aronnebrivio:feat/ecovacs-missing-functionalities

Conversation

@aronnebrivio
Copy link
Copy Markdown
Contributor

@aronnebrivio aronnebrivio commented Oct 30, 2025

Proposed change

  • Add auto empty frequency sensor

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

home-assistant/home-assistant.io#41541

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • I have followed the [perfect PR recommendations][perfect-pr]
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @mib1185, @edenhaus, @Augar, mind taking a look at this pull request as it has been labeled with an integration (ecovacs) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of ecovacs can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign ecovacs Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@edenhaus edenhaus changed the title feat(ecovacs): add border spin and auto empty sensors and switches Add border spin and auto empty entities to Ecovacs Oct 30, 2025
Copy link
Copy Markdown
Member

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please split the PR into two: One adding the sensor entity and the other the switch entity

Also please add test for it

@home-assistant home-assistant Bot marked this pull request as draft October 30, 2025 12:21
@home-assistant
Copy link
Copy Markdown
Contributor

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@aronnebrivio aronnebrivio force-pushed the feat/ecovacs-missing-functionalities branch from 6a1231c to e8a87f3 Compare October 30, 2025 14:31
@aronnebrivio aronnebrivio force-pushed the feat/ecovacs-missing-functionalities branch from e8a87f3 to 8ffd7a5 Compare October 30, 2025 15:34
@aronnebrivio aronnebrivio changed the title Add border spin and auto empty entities to Ecovacs Add auto empty sensor to Ecovacs Oct 30, 2025
@aronnebrivio aronnebrivio requested a review from edenhaus October 30, 2025 16:11
@aronnebrivio aronnebrivio marked this pull request as ready for review October 30, 2025 16:11
Copy link
Copy Markdown
Member

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aronnebrivio 👍

Also here we need a docs PR :)

@aronnebrivio
Copy link
Copy Markdown
Contributor Author

aronnebrivio commented Oct 30, 2025

Hey @edenhaus, I should have everything sorted out. Sorry for the mess, it's my first contribution and I made a bit of a mess. Thanks!

@edenhaus
Copy link
Copy Markdown
Member

Hey @edenhaus, I should have everything sorted out. Sorry for the mess, it's my first contribution and I made a bit of a mess. Thanks!

No problem :) We are here to help and guide :)

@edenhaus edenhaus merged commit 092841c into home-assistant:dev Oct 31, 2025
36 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants