Add auto empty sensor to Ecovacs#155489
Conversation
|
Hey there @mib1185, @edenhaus, @Augar, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
edenhaus
left a comment
There was a problem hiding this comment.
Please split the PR into two: One adding the sensor entity and the other the switch entity
Also please add test for it
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
6a1231c to
e8a87f3
Compare
e8a87f3 to
8ffd7a5
Compare
edenhaus
left a comment
There was a problem hiding this comment.
Thanks @aronnebrivio 👍
Also here we need a docs PR :)
|
Hey @edenhaus, I should have everything sorted out. Sorry for the mess, it's my first contribution and I made a bit of a mess. Thanks! |
No problem :) We are here to help and guide :) |
Proposed change
Type of change
Additional information
home-assistant/home-assistant.io#41541
Checklist
ruff format homeassistant tests)