Add quality scale for WLED #155482
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,92 @@ | ||
| rules: | ||
|
Member
There was a problem hiding this comment. The location of the WLED repo has changed btw, so we should update the release URL |
||
| # Bronze | ||
| action-setup: | ||
| status: exempt | ||
| comment: This integration does not have custom service actions. | ||
| appropriate-polling: done | ||
| brands: done | ||
| common-modules: done | ||
| config-flow-test-coverage: | ||
| status: todo | ||
| comment: | | ||
| test_connection_error and test_unsupported_version_error should end in CREATE_ENTRY | ||
| config-flow: done | ||
| dependency-transparency: done | ||
| docs-actions: | ||
| status: exempt | ||
| comment: This integration does not have custom service actions. | ||
| docs-high-level-description: done | ||
| docs-installation-instructions: done | ||
| docs-removal-instructions: done | ||
| entity-event-setup: done | ||
| entity-unique-id: done | ||
| has-entity-name: done | ||
| runtime-data: done | ||
| test-before-configure: done | ||
| test-before-setup: done | ||
| unique-config-entry: done | ||
|
|
||
| # Silver | ||
| action-exceptions: todo | ||
| config-entry-unloading: done | ||
| docs-configuration-parameters: done | ||
| docs-installation-parameters: todo | ||
| entity-unavailable: | ||
| status: todo | ||
| comment: | | ||
| The WLEDSegmentLight.available property can just be an if .. in .. check | ||
| integration-owner: done | ||
| log-when-unavailable: done | ||
| parallel-updates: done | ||
| reauthentication-flow: | ||
| status: exempt | ||
| comment: | | ||
| This integration does not require authentication. | ||
| test-coverage: | ||
| status: todo | ||
| comment: | | ||
| The test_setting_unique_id test is redundant. | ||
| The test_websocket_already_connected test can use the freezer. | ||
| The snapshot tests should be used more widely. | ||
| We should use pytest.mark.freeze_time instead of mock. | ||
| # Gold | ||
| devices: done | ||
| diagnostics: done | ||
| discovery-update-info: done | ||
| discovery: done | ||
| docs-data-update: todo | ||
| docs-examples: done | ||
| docs-known-limitations: | ||
| status: todo | ||
| comment: | | ||
| Analog RGBCCT Strip are poor supported by HA. | ||
| See: https://github.com/home-assistant/core/issues/123614 | ||
| docs-supported-devices: todo | ||
| docs-supported-functions: done | ||
| docs-troubleshooting: todo | ||
| docs-use-cases: todo | ||
| dynamic-devices: | ||
| status: exempt | ||
| comment: | | ||
| This integration has a fixed single device. | ||
| entity-category: done | ||
| entity-device-class: | ||
| status: todo | ||
| comment: Led count could receive unit of measurement | ||
| entity-disabled-by-default: done | ||
| entity-translations: done | ||
| exception-translations: done | ||
| icon-translations: done | ||
| reconfiguration-flow: done | ||
| repair-issues: | ||
| status: exempt | ||
| comment: This integration does not have any known issues that require repair. | ||
| stale-devices: | ||
| status: exempt | ||
| comment: | | ||
| This integration has a fixed single device. | ||
|
|
||
| # Platinum | ||
| async-dependency: done | ||
| inject-websession: done | ||
| strict-typing: done | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1060,7 +1060,6 @@ class Rule: | |
| "wirelesstag", | ||
| "withings", | ||
| "wiz", | ||
| "wmspro", | ||
| "wolflink", | ||
| "workday", | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe the nightlight could eventually become their own entity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I understand. "Nightlight" is a timer that turns the light off after a certain time, so the switch type seems fine to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, there are extra state attributes that might warrant their own entity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if many people use the nightlight in WLED if the same can be done in HA. This entity mainly collects history when someone triggered it from the WLED UI.