Skip to content

Remove media_source platform from Xbox integration#155433

Closed
tr4nt0r wants to merge 1 commit into
home-assistant:devfrom
tr4nt0r:xbox_remove_media_source
Closed

Remove media_source platform from Xbox integration#155433
tr4nt0r wants to merge 1 commit into
home-assistant:devfrom
tr4nt0r:xbox_remove_media_source

Conversation

@tr4nt0r
Copy link
Copy Markdown
Contributor

@tr4nt0r tr4nt0r commented Oct 29, 2025

Breaking change

Temporary removal of the media source platform

The media source has been broken for a long time and fixing it requires fixing things in the upstream library, which currently seems to be orphaned. Giving it some time to see if my PRs get merged or if I have to make a fork of the library. I am currently also redoing the media source platform from ground, as it has various issues and does not support multiple config entries (Xbox is therefore currently limited to single entry).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @hunterjm, mind taking a look at this pull request as it has been labeled with an integration (xbox) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of xbox can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign xbox Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@tr4nt0r tr4nt0r changed the title Remove media_source platform Remove media_source platform from Xbox integration Oct 29, 2025
@thecode
Copy link
Copy Markdown
Member

thecode commented Oct 29, 2025

Temporary removal of the media source platform

My personal opinion, not a formal review, even if it doesn't work, now you are making a breaking change, which if doesn't merge today will only show up on the next major release, (2025.12) and when you fix it, you will have to wait for another major release since it would be a new feature.

If you leave it like this once you are ready you can bump the lib and fix it, even on patch release.

@tr4nt0r
Copy link
Copy Markdown
Contributor Author

tr4nt0r commented Oct 29, 2025

Yes, I'm aware of that, but as I am rewriting it completely I would prefer to submit it as a new feature. Also I don't expect a new release of the library, the last release is 3 years old.

@tr4nt0r tr4nt0r marked this pull request as draft October 31, 2025 03:53
@tr4nt0r
Copy link
Copy Markdown
Contributor Author

tr4nt0r commented Oct 31, 2025

I forked the library, so this might no longer be required, if the library switch is accepted #155536

@abmantis
Copy link
Copy Markdown
Member

abmantis commented Nov 3, 2025

I forked the library, so this might no longer be required, if the library switch is accepted #155536

Closing this then since #155536 is merged. Thanks @tr4nt0r !

@abmantis abmantis closed this Nov 3, 2025
@tr4nt0r tr4nt0r deleted the xbox_remove_media_source branch November 3, 2025 19:38
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants