Remove media_source platform from Xbox integration#155433
Conversation
|
Hey there @hunterjm, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
My personal opinion, not a formal review, even if it doesn't work, now you are making a breaking change, which if doesn't merge today will only show up on the next major release, ( If you leave it like this once you are ready you can bump the lib and fix it, even on patch release. |
|
Yes, I'm aware of that, but as I am rewriting it completely I would prefer to submit it as a new feature. Also I don't expect a new release of the library, the last release is 3 years old. |
|
I forked the library, so this might no longer be required, if the library switch is accepted #155536 |
Breaking change
Temporary removal of the media source platform
The media source has been broken for a long time and fixing it requires fixing things in the upstream library, which currently seems to be orphaned. Giving it some time to see if my PRs get merged or if I have to make a fork of the library. I am currently also redoing the media source platform from ground, as it has various issues and does not support multiple config entries (Xbox is therefore currently limited to single entry).
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: