RFC: Only use supported light properties#15484
Merged
balloob merged 2 commits intohome-assistant:devfrom Jul 18, 2018
Merged
Conversation
Member
|
From a quick look (w/o testing) this looks what one should be expecting already; when the platform itself already reports its supported features, it should not have to need to guard accesses to irrelevant features 👍 |
Member
|
I think that this is too what I would expect. |
balloob
approved these changes
Jul 18, 2018
8 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Many light platforms support multiple products with differing features. This means that they can have properties that are not actually valid for the active device and will potentially fail when accessed. An example of such an issue is #15339.
This PR changes the light component so it only reads properties that are relevant for the supported features. Thus, light platforms will not have to guard each property that could be invalid.
The change could reveal some missing features like I fixed in a few tests.
I am unsure about the change to
light/mqtt.pyand I would like help to avoid thepylintcomment.Related issue (if applicable): fixes #
Checklist:
tox.If the code does not interact with devices: