Cleanup of HomematicIP Cloud code#15475
Merged
balloob merged 8 commits intohome-assistant:devfrom Jul 18, 2018
worm-ee:cleanup-homematicip_cloud
Merged
Cleanup of HomematicIP Cloud code#15475balloob merged 8 commits intohome-assistant:devfrom worm-ee:cleanup-homematicip_cloud
balloob merged 8 commits intohome-assistant:devfrom
worm-ee:cleanup-homematicip_cloud
Conversation
homeassistant
added
cla-signed
integration: homematicip_cloud
small-pr
ghost
added
the
houndci-bot
reviewed
Jul 15, 2018
| ATTR_MODEL_TYPE: self._device.modelType | ||
| } | ||
| attr = {ATTR_MODEL_TYPE: self._device.modelType} | ||
| if hasattr(self._device, 'lowBat') and self._device.lowBat: |
Contributor
Author
|
@MartinHjelmare What do you think? There is now only information showed if really necessary. |
| """Return the icon.""" | ||
| if hasattr(self._device, 'lowBat') and self._device.lowBat: | ||
| return 'mdi:battery-outline' | ||
|
|
Member
There was a problem hiding this comment.
Return None, if this case is not true.
worm-ee
changed the title
balloob
approved these changes
Jul 18, 2018
michaeldavie
pushed a commit
to michaeldavie/home-assistant
that referenced
this pull request
Jul 31, 2018
* Check if device supports lowBat and shows it only if battery is low * Show empty battery icon if lowBat is true * Default return None * Sabotage attribute and icon if device has this feature * Bug fix and cleanup * Use dedicated function for security state * Cleanup of sensor attributes and icons * Empty
Merged
girlpunk
pushed a commit
to girlpunk/home-assistant
that referenced
this pull request
Sep 4, 2018
* Check if device supports lowBat and shows it only if battery is low * Show empty battery icon if lowBat is true * Default return None * Sabotage attribute and icon if device has this feature * Bug fix and cleanup * Use dedicated function for security state * Cleanup of sensor attributes and icons * Empty
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
alarm_control_panel- lib update and fix of home/away armedChecklist:
tox. Your PR cannot be merged unless tests passIf the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.