Skip to content

Implement locate service for neato#15467

Merged
balloob merged 2 commits intohome-assistant:devfrom
dshokouhi:neato_locate_service
Jul 18, 2018
Merged

Implement locate service for neato#15467
balloob merged 2 commits intohome-assistant:devfrom
dshokouhi:neato_locate_service

Conversation

@dshokouhi
Copy link
Copy Markdown
Member

@dshokouhi dshokouhi commented Jul 14, 2018

Description:

This PR adds support for vacuum.locate service call for neato vacuums. Useful for when the status of the botvac is "stuck".

Related issue (if applicable): fixes #

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>

Example entry for configuration.yaml (if applicable):

neato:
  username: user
  password: pass

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.


def locate(self, **kwargs):
"""Locate the robot by making it emit a sound."""
self.robot.locate() No newline at end of file
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no newline at end of file

@balloob balloob merged commit 06c3f75 into home-assistant:dev Jul 18, 2018
@ghost ghost removed the in progress label Jul 18, 2018
@dshokouhi dshokouhi deleted the neato_locate_service branch July 18, 2018 14:37
@balloob balloob mentioned this pull request Aug 3, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Dec 10, 2018
@ghost ghost removed the platform: vacuum.neato label Mar 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants