-
-
Notifications
You must be signed in to change notification settings - Fork 37.4k
Add download file service to Telegram bot integration #154625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
59 commits
Select commit
Hold shift + click to select a range
001fe1c
Add download file service to Telegram bot integration
aviadlevy 369027c
rename to directory_path
aviadlevy 7e23945
paramaterize tests to cover user providing / not providing file_name
aviadlevy 8102083
Add test for failed to get file
aviadlevy d9a30ea
add test user providing directory path
aviadlevy 95ec8fa
Update default directory path for file downloads and add validation f…
aviadlevy 43263e4
fix got an unexpected keyword argument 'config_entry_id'
aviadlevy 542eb0d
Add handling for external directory paths in file download test
aviadlevy d327ee5
Merge remote-tracking branch 'origin' into download_file
aviadlevy 413b260
Use DOMAIN constant
aviadlevy cde1749
fix description
aviadlevy e8455a4
Use native hass methods for directory handling
aviadlevy 61326f2
make sure directory creation is async
aviadlevy 3a25d16
do not create new temp folder on test
aviadlevy 2ccd5d4
Add 1 more test case
aviadlevy 4cac8bc
improve test slightly more
aviadlevy a8c185e
prevent potential race condition
aviadlevy ba5b8a1
Merge branch 'dev' into download_file
aviadlevy 8968a78
Merge branch 'dev' into download_file
frenck 159b048
Merge branch 'dev' into download_file
aviadlevy 6b1220a
use better paramaterize so no need for conditions
aviadlevy b84b0f2
try-except the download action
aviadlevy 223c7e0
Merge branch 'dev' into download_file
aviadlevy d67b9dd
Merge branch 'dev' into download_file
aviadlevy 019dbcd
Merge branch 'dev' into download_file
aviadlevy e8a62cc
Merge remote-tracking branch 'origin/dev' into download_file
aviadlevy fc72351
Merge branch 'dev' into download_file
aviadlevy d1bf419
Merge branch 'dev' into download_file
aviadlevy 8978426
Merge branch 'dev' into download_file
aviadlevy 3b09c16
Improve code to make more natively async
aviadlevy a3b31a7
Merge branch 'dev' into download_file
aviadlevy e149e2f
Merge branch 'dev' into download_file
aviadlevy bd0de06
Merge branch 'dev' into download_file
aviadlevy 771e9f6
Merge branch 'dev' into download_file
aviadlevy 5c5ef41
Merge remote-tracking branch 'origin/dev' into download_file
aviadlevy 0784704
Merge branch 'dev' into download_file
aviadlevy 76ada0e
Merge branch 'dev' into download_file
aviadlevy f29f7d8
Merge remote-tracking branch 'origin/dev' into download_file
aviadlevy c2a2a22
Merge branch 'download_file' of github.com:aviadlevy/core into downlo…
aviadlevy 4119222
solve PR comments
aviadlevy b01f529
Merge branch 'dev' into download_file
aviadlevy c7b0cdf
better I/O handling
aviadlevy 4473fa8
debug why fail only on CI
aviadlevy 24010ef
Updated test_telegram_bot.py to add the resolved Path to the allowlist
aviadlevy 522b325
keep directory for tests
aviadlevy 5ea4fc0
create missing test telegram config dir if not exists
aviadlevy adeda1e
Merge branch 'dev' into download_file
aviadlevy d4d3ff6
better handle dir creation and add test for not exists dir
aviadlevy 0542ddf
use tmp_path fixture
aviadlevy 7cb9a0c
Merge branch 'dev' into download_file
aviadlevy d6864ec
Capitallize and remove comment
aviadlevy d2e176f
split custom / no-custom dir tests
aviadlevy 5256307
Set response support to ONLY for SERVICE_DOWNLOAD_FILE
aviadlevy 47004a4
set return response true for download_file tests
aviadlevy 0aea16f
download file service to SupportsResponse.OPTIONAL
aviadlevy 7bc69f0
Add ServiceResponse to download_file service tests and validate respo…
aviadlevy 9784416
extract common assertions
aviadlevy 9cd46fe
Catch also TelegramError
aviadlevy 4d0aa4f
Add more test coverage for errors during file download
aviadlevy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.