Customizable command timeout#15442
Merged
fabaff merged 3 commits intohome-assistant:devfrom Jul 17, 2018
Merged
Conversation
homeassistant
added
cla-signed
platform: sensor.command_line
small-pr
ghost
added
the
houndci-bot
reviewed
Jul 13, 2018
| command = config.get(CONF_COMMAND) | ||
| unit = config.get(CONF_UNIT_OF_MEASUREMENT) | ||
| value_template = config.get(CONF_VALUE_TEMPLATE) | ||
| command_timeout= config.get(CONF_COMMAND_TIMEOUT) |
There was a problem hiding this comment.
missing whitespace around operator
| vol.Optional(CONF_NAME, default=DEFAULT_NAME): cv.string, | ||
| vol.Optional(CONF_UNIT_OF_MEASUREMENT): cv.string, | ||
| vol.Optional(CONF_VALUE_TEMPLATE): cv.template, | ||
| vol.Optional(CONF_COMMAND_TIMEOUT, default=DEFAULT_TIMEOUT): cv.positive_int, |
There was a problem hiding this comment.
line too long (81 > 79 characters)
| SCAN_INTERVAL = timedelta(seconds=60) | ||
|
|
||
| CONF_COMMAND_TIMEOUT='timeout' | ||
| DEFAULT_TIMEOUT='15' |
There was a problem hiding this comment.
missing whitespace around operator
|
|
||
| SCAN_INTERVAL = timedelta(seconds=60) | ||
|
|
||
| CONF_COMMAND_TIMEOUT='timeout' |
There was a problem hiding this comment.
missing whitespace around operator
2 tasks
mu4yu3
force-pushed
the
lich_sensor.command_line
branch
from
5d7c165 to
60a81d5
Compare
fabaff
reviewed
Jul 13, 2018
| SCAN_INTERVAL = timedelta(seconds=60) | ||
|
|
||
| CONF_COMMAND_TIMEOUT ='command_timeout' | ||
| DEFAULT_TIMEOUT ='15' |
Member
There was a problem hiding this comment.
This should be an int not a string.
Member
|
You need to update the tests, too. |
Contributor
Author
|
I have tested it locally and the result is successful. |
Member
|
That might be but there are unit tests which needs to be updated. This is why Travis fails. |
houndci-bot
reviewed
Jul 15, 2018
| vol.Optional(CONF_UNIT_OF_MEASUREMENT): cv.string, | ||
| vol.Optional(CONF_VALUE_TEMPLATE): cv.template, | ||
| vol.Optional(CONF_COMMAND_TIMEOUT, default=DEFAULT_TIMEOUT | ||
| ): cv.positive_int, |
There was a problem hiding this comment.
closing bracket does not match visual indentation
| vol.Optional(CONF_DEVICE_CLASS): DEVICE_CLASSES_SCHEMA, | ||
| vol.Optional(CONF_VALUE_TEMPLATE): cv.template, | ||
| vol.Optional(CONF_COMMAND_TIMEOUT, default=DEFAULT_TIMEOUT | ||
| ): cv.positive_int, |
There was a problem hiding this comment.
closing bracket does not match visual indentation
mu4yu3
force-pushed
the
lich_sensor.command_line
branch
from
f34476d to
f5b30b5
Compare
michaeldavie
pushed a commit
to michaeldavie/home-assistant
that referenced
this pull request
Jul 31, 2018
* Customizable command timeout * Change string to int * update the tests. Do the same thing on the binary_sensor.command_line.
Merged
girlpunk
pushed a commit
to girlpunk/home-assistant
that referenced
this pull request
Sep 4, 2018
* Customizable command timeout * Change string to int * update the tests. Do the same thing on the binary_sensor.command_line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Related issue (if applicable): fixes #
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#5782
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: