Skip to content

Fix for multiple Lyrion Music Server on a single Home Assistant server for Squeezebox#154081

Merged
joostlek merged 1 commit into
home-assistant:devfrom
peteS-UK:fix_multiple_lms
Oct 10, 2025
Merged

Fix for multiple Lyrion Music Server on a single Home Assistant server for Squeezebox#154081
joostlek merged 1 commit into
home-assistant:devfrom
peteS-UK:fix_multiple_lms

Conversation

@peteS-UK
Copy link
Copy Markdown
Contributor

@peteS-UK peteS-UK commented Oct 9, 2025

Proposed change

There is a bug in the Squeezebox integration if you have multiple Lyrion Music Servers added to a single Home Assistant instance. The integration uses dispatchers to trigger the creation of new entities, but the signal name is currently generic. This means that if you have multiple LMS configured, each integration is listening for the same named signal, leading to the integration trying to add a new player to multiple LMS config entries . This fix extends the name of the signal using the config entry id, so that different config entries each have unique named signals.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Oct 9, 2025

Hey there @rajlaud, @pssc, mind taking a look at this pull request as it has been labeled with an integration (squeezebox) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of squeezebox can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign squeezebox Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@joostlek joostlek merged commit 07f3e00 into home-assistant:dev Oct 10, 2025
34 checks passed
@joostlek joostlek added this to the 2025.10.2 milestone Oct 10, 2025
frenck pushed a commit that referenced this pull request Oct 10, 2025
@frenck frenck mentioned this pull request Oct 10, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants