Add async_iterator util#153194
Merged
Merged
Conversation
Contributor
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR extracts async iterator utility classes from the backup integration and moves them to a shared location in homeassistant.util.async_iterator, making them available for reuse across the codebase.
- Adds new
AsyncIteratorReaderandAsyncIteratorWriterclasses tohomeassistant/util/async_iterator.py - Updates the backup integration to use the shared utilities instead of local implementations
- Replaces the backup-specific
AbortCipherexception with a genericAbortexception
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
homeassistant/util/async_iterator.py |
New module containing AsyncIteratorReader, AsyncIteratorWriter classes and Abort exception |
tests/util/test_async_iterator.py |
Comprehensive test suite for the new async iterator utilities |
homeassistant/components/backup/util.py |
Removes local implementations and imports from shared module, updates exception handling |
homeassistant/components/backup/manager.py |
Updates import and constructor call to use shared AsyncIteratorReader |
homeassistant/components/backup/http.py |
Updates imports and constructor calls to use shared utilities |
Comment on lines
+78
to
+79
| """Close the iterator.""" | ||
|
|
There was a problem hiding this comment.
The close method has an empty implementation. Consider adding documentation to clarify that this is intentionally a no-op or implement proper cleanup if needed.
Suggested change
| """Close the iterator.""" | |
| """Close the iterator. | |
| This method is intentionally a no-op as no cleanup is required. | |
| """ |
MartinHjelmare
approved these changes
Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Add async_iterator util with classes
AsyncIteratorReaderandAsyncIteratorWriterRationale: The helper classes are useful outside the backup integration
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: