Skip to content

Fix exception when parts of Pollen.com can't be reached#15296

Merged
bachya merged 1 commit into
home-assistant:devfrom
bachya:pollen
Jul 4, 2018
Merged

Fix exception when parts of Pollen.com can't be reached#15296
bachya merged 1 commit into
home-assistant:devfrom
bachya:pollen

Conversation

@bachya
Copy link
Copy Markdown
Contributor

@bachya bachya commented Jul 4, 2018

Description:

#15286 revealed an unhandled exception when parts of Pollen.com's back-of-house API are down. This PR halts updating when such an exception occurs.

Related issue (if applicable): fixes #15286

Pull request in home-assistant.github.io with documentation (if applicable): N/A

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: pollen
    zip_code: "12345"
    monitored_conditions:
      - allergy_average_forecasted
      - allergy_average_historical
      - allergy_index_today
      - allergy_index_tomorrow
      - allergy_index_yesterday
      - disease_average_forecasted

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:
- [ ] Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:
- [ ] New dependencies have been added to the REQUIREMENTS variable (example).
- [ ] New dependencies are only imported inside functions that use them (example).
- [ ] New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
- [ ] New files were added to .coveragerc.

If the code does not interact with devices:
- [ ] Tests have been added to verify that the new code works.

@bachya bachya added this to the 0.73 milestone Jul 4, 2018
@bachya bachya self-assigned this Jul 4, 2018
@ghost ghost added the in progress label Jul 4, 2018
@bachya bachya changed the title Fixed exception when parts of Pollen.com can't be reached Fix exception when parts of Pollen.com can't be reached Jul 4, 2018
@bachya bachya merged commit f65c394 into home-assistant:dev Jul 4, 2018
@ghost ghost removed the in progress label Jul 4, 2018
@bachya bachya deleted the pollen branch July 4, 2018 23:30
awarecan pushed a commit to awarecan/home-assistant that referenced this pull request Jul 16, 2018
…nt#15296)

Fix exception when parts of Pollen.com can't be reached
girlpunk pushed a commit to girlpunk/home-assistant that referenced this pull request Sep 4, 2018
…nt#15296)

Fix exception when parts of Pollen.com can't be reached
@home-assistant home-assistant locked and limited conversation to collaborators Dec 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Pollen.com] No longer retrieving pollen forecasts

2 participants