Fix exception when parts of Pollen.com can't be reached#15296
Merged
Conversation
awarecan
pushed a commit
to awarecan/home-assistant
that referenced
this pull request
Jul 16, 2018
…nt#15296) Fix exception when parts of Pollen.com can't be reached
girlpunk
pushed a commit
to girlpunk/home-assistant
that referenced
this pull request
Sep 4, 2018
…nt#15296) Fix exception when parts of Pollen.com can't be reached
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
#15286 revealed an unhandled exception when parts of Pollen.com's back-of-house API are down. This PR halts updating when such an exception occurs.
Related issue (if applicable): fixes #15286
Pull request in home-assistant.github.io with documentation (if applicable): N/A
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
- [ ] Documentation added/updated in home-assistant.github.ioIf the code communicates with devices, web services, or third-party tools:
- [ ] New dependencies have been added to theREQUIREMENTSvariable (example).- [ ] New dependencies are only imported inside functions that use them (example).- [ ] New or updated dependencies have been added torequirements_all.txtby runningscript/gen_requirements_all.py.- [ ] New files were added to.coveragerc.If the code does not interact with devices:
- [ ] Tests have been added to verify that the new code works.