Skip to content

Fix yeelight light brightness#15290

Merged
bachya merged 1 commit into
home-assistant:devfrom
cdce8p:fix-yeelight-brightness
Jul 4, 2018
Merged

Fix yeelight light brightness#15290
bachya merged 1 commit into
home-assistant:devfrom
cdce8p:fix-yeelight-brightness

Conversation

@cdce8p
Copy link
Copy Markdown
Member

@cdce8p cdce8p commented Jul 3, 2018

Description:

The brightness should always be an integer.

Related issue (if applicable): fixes #14354 (comment)

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

@cdce8p cdce8p requested a review from rytilahti as a code owner July 3, 2018 21:07
@ghost ghost assigned cdce8p Jul 3, 2018
@ghost ghost added the in progress label Jul 3, 2018
@cdce8p cdce8p added the bug label Jul 3, 2018
@cdce8p cdce8p added this to the 0.73 milestone Jul 3, 2018
@cdce8p cdce8p removed their assignment Jul 3, 2018
@bachya bachya merged commit 4277514 into home-assistant:dev Jul 4, 2018
@ghost ghost removed the in progress label Jul 4, 2018
@bachya
Copy link
Copy Markdown
Contributor

bachya commented Jul 4, 2018

Thanks! 😎

@cdce8p cdce8p deleted the fix-yeelight-brightness branch July 4, 2018 05:50
awarecan pushed a commit to awarecan/home-assistant that referenced this pull request Jul 16, 2018
girlpunk pushed a commit to girlpunk/home-assistant that referenced this pull request Sep 4, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Dec 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Homekit component does not provide proper brightness on Z-Wave lights

3 participants