Skip to content

Add option MY to new devices #15264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghost wants to merge 1 commit into from
Closed

Add option MY to new devices #15264

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions homeassistant/components/cover/tahoma.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,5 +83,13 @@ def stop_cover(self, **kwargs):
('rts:BlindRTSComponent',
'io:ExteriorVenetianBlindIOComponent'):
self.apply_action('my')
elif self.tahoma_device.type == 'rts:VenetianBlindRTSComponent':
self.apply_action('my')
elif self.tahoma_device.type == 'rts:DualCurtainRTSComponent':
self.apply_action('my')
elif self.tahoma_device.type == 'rts:ExteriorVenetianBlindRTSComponent':
Copy link
Copy Markdown

@houndci-bot houndci-bot Jul 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line too long (80 > 79 characters)

self.apply_action('my')
elif self.tahoma_device.type == 'rts:BlindRTSComponent':
self.apply_action('my')
Copy link
Copy Markdown
Member

@fabaff fabaff Jul 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those devices should be added to the existing list.

Copy link
Copy Markdown
Author

@ghost ghost Jul 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I send PR to add this...

Copy link
Copy Markdown
Member

@fabaff fabaff Jul 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The devices you added should be part of the list starting on line 83.

else:
self.apply_action('stopIdentify')