Make LIFX color/temperature attributes mutually exclusive#15234
Merged
balloob merged 1 commit intohome-assistant:devfrom Jul 1, 2018
Merged
Make LIFX color/temperature attributes mutually exclusive#15234balloob merged 1 commit intohome-assistant:devfrom
balloob merged 1 commit intohome-assistant:devfrom
Conversation
homeassistant
added
cla-signed
platform: light.lifx
small-pr
ghost
assigned
balloob
pushed a commit
that referenced
this pull request
Jul 1, 2018
Merged
girlpunk
pushed a commit
to girlpunk/home-assistant
that referenced
this pull request
Sep 4, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Since a light cannot be white and colored at the same time, this PR changes LIFX to only report one of the
hs_color/color_tempattributes. LIFX does not have separate color/white modes so we treat it as white when the color is fully desaturated.Breaking change: LIFX will no longer report
hs_color/rgb_colorandcolor_tempsimultaneously.Checklist:
tox.If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.