Only create front-end client_id once#15214
Merged
balloob merged 6 commits intohome-assistant:devfrom Jul 1, 2018
Merged
Conversation
ghost
added
the
balloob
reviewed
Jun 29, 2018
|
|
||
| redirect_uris_counter = Counter(redirect_uris) | ||
|
|
||
| for _, client in self.clients.items(): |
balloob
reviewed
Jun 29, 2018
| redirect_uris_counter = Counter(redirect_uris) | ||
|
|
||
| for _, client in self.clients.items(): | ||
| if (client.name == name |
Member
There was a problem hiding this comment.
I think that we should just match on name and not allow clients with duplicate names. That can only confuse users.
balloob
approved these changes
Jul 1, 2018
balloob
pushed a commit
that referenced
this pull request
Jul 1, 2018
* Only create frontend client_id once * Check user and client_id before create refresh token * Lint * Follow code review comment * Minor clenaup * Update doc string
Merged
girlpunk
pushed a commit
to girlpunk/home-assistant
that referenced
this pull request
Sep 4, 2018
* Only create frontend client_id once * Check user and client_id before create refresh token * Lint * Follow code review comment * Minor clenaup * Update doc string
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Only create front-end client_id once
Check user and client_id before create refresh token
Related issue (if applicable): fixes #15208 fixes #15201
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: