Skip to content

Conversation

@felipecrs
Copy link
Contributor

@felipecrs felipecrs commented Sep 4, 2025

Proposed change

This PR fixes the Supervisor Ingress proxy for WebSocket connections of add-ons not properly forward the ping/pong frames. The ping/pong data was not being passed along, which is important depending on how the keepalive mechanism was implemented. This is stated in the RFC 6455, section 5.5.2.

For more context, please check home-assistant/supervisor#6144.

Note this PR has no dependency in home-assistant/supervisor#6144, although both needs to be merged in order to fully fix the issue reported in home-assistant/supervisor#6143.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copilot AI review requested due to automatic review settings September 4, 2025 03:32
@home-assistant
Copy link

home-assistant bot commented Sep 4, 2025

Hey there @home-assistant/supervisor, mind taking a look at this pull request as it has been labeled with an integration (hassio) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of hassio can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign hassio Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug in the Supervisor Ingress WebSocket proxy where ping/pong frame data was not being forwarded correctly. The issue violated RFC 6455 requirements for WebSocket keepalive mechanisms.

Key changes:

  • Modified ping frame forwarding to include frame data
  • Modified pong frame forwarding to include frame data

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @felipecrs 👍

../Frenck

@frenck frenck merged commit c2290d6 into home-assistant:dev Sep 4, 2025
47 of 48 checks passed
@felipecrs felipecrs deleted the fix-addon-proxy branch September 4, 2025 13:01
@felipecrs
Copy link
Contributor Author

Thanks for merging!

@frenck can I request it to be cherry-picked to stable?

@agners agners added this to the 2025.9.1 milestone Sep 4, 2025
@frenck
Copy link
Member

frenck commented Sep 4, 2025

Seems like Stefan already did 👍 😄

@felipecrs
Copy link
Contributor Author

Awesome, thank you both!

@frenck frenck mentioned this pull request Sep 5, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Sep 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ingress closes add-on WebSocket connections on every 40s

4 participants