Add language to dark sky weather component#15130
Merged
Conversation
homeassistant
added
cla-signed
platform: weather.darksky
small-pr
ghost
assigned
bachya
reviewed
Jun 25, 2018
Contributor
bachya
left a comment
bachya
left a comment
There was a problem hiding this comment.
Looks good overall! Just a few small nits.
| @@ -45,13 +60,14 @@ def setup_platform(hass, config, add_devices, discovery_info=None): | |||
| latitude = config.get(CONF_LATITUDE, hass.config.latitude) | |||
| longitude = config.get(CONF_LONGITUDE, hass.config.longitude) | |||
| name = config.get(CONF_NAME) | |||
Contributor
There was a problem hiding this comment.
Since you give this a default, you don't need .get: just access it directly.
| latitude = config.get(CONF_LATITUDE, hass.config.latitude) | ||
| longitude = config.get(CONF_LONGITUDE, hass.config.longitude) | ||
| name = config.get(CONF_NAME) | ||
| lang = config.get(CONF_LANGUAGE) |
Contributor
There was a problem hiding this comment.
Since you give this a default, you don't need .get: just access it directly.
|
|
||
| dark_sky = DarkSkyData( | ||
| config.get(CONF_API_KEY), latitude, longitude, units) | ||
| config.get(CONF_API_KEY), latitude, longitude, units, lang) |
Contributor
There was a problem hiding this comment.
Since this is listed as required in the schema, you don't need .get: just access it directly.
Member
Author
|
In a future PR, I will fix also the icons for the weather UI. |
Member
|
This only works for the current weather text. Forecast and icons are still "broken" as they are not mapped correctly |
Member
|
The proper fix is to do the mapping right. |
pvizeli
added a commit
that referenced
this pull request
Jun 25, 2018
* Revert "Fix #14919. Should throw exception when camera stream closed by frontend (#15028)" This reverts commit 508d045. * Revert "Fix pylintrc section order and option placements (#15120)" This reverts commit dbae410. * Revert "Add storage helper and migrate config entries (#15045)" This reverts commit ae51dc0. * Revert "Add language to dark sky weather component (#15130)" This reverts commit 672a3c7.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Add support for language in dark sky weather component.