-
-
Notifications
You must be signed in to change notification settings - Fork 37.4k
Add Facebox teach service #14998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
MartinHjelmare
merged 22 commits into
home-assistant:dev
from
robmarkcole:facebox-teach-service
Jul 10, 2018
Merged
Add Facebox teach service #14998
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
0a85a53
Adds service
robmarkcole c9d68f3
Address pylint
robmarkcole d503b4c
Update facebox.py
robmarkcole f529b7d
patch tests
robmarkcole d9292a7
Update facebox.py
robmarkcole d4ef2ff
Update test_facebox.py
robmarkcole 2eed0d9
Update facebox.py
robmarkcole 8b1791e
Update facebox.py
robmarkcole a1751ec
Update facebox.py
robmarkcole 4664c93
Update test_facebox.py
robmarkcole d87bddd
Update test_facebox.py
robmarkcole 0179d37
Update facebox.py
robmarkcole 863ebd6
Update facebox.py
robmarkcole 851b970
Update facebox.py
robmarkcole 182be06
Update facebox.py
robmarkcole 4ba767f
Adds total_matched_faces
robmarkcole 8c8f413
Update test_facebox.py
robmarkcole 74f7f0b
Update facebox.py
robmarkcole cf6497a
Update test_facebox.py
robmarkcole 6a23b19
Update test_facebox.py
robmarkcole 5bf7a13
Remove fixtures
robmarkcole 49a33f5
Fix teach service test and lint issues
MartinHjelmare File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this our standard format for event names? Have you checked other platforms or components that fire events?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see a consistent format, so took my lead from
EVENT_DETECT_FACE = 'image_processing.detect_face'. I thinkteach_classifieris pretty a accurate description, but am open to other suggestions?